Skip to content

Remove CUDA 11 branches for sparse code#164531

Closed
cyyever wants to merge 4 commits intopytorch:mainfrom
cyyever:cleanup_cuda11_3
Closed

Remove CUDA 11 branches for sparse code#164531
cyyever wants to merge 4 commits intopytorch:mainfrom
cyyever:cleanup_cuda11_3

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 3, 2025

This PR removes outdated CUDA version checks from sparse code in aten/src/ATen/cuda.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164531

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c22f962 with merge base ef50c6e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Oct 3, 2025
@cyyever cyyever marked this pull request as draft October 3, 2025 00:55
@cyyever cyyever requested a review from ezyang October 3, 2025 01:46
@cyyever cyyever force-pushed the cleanup_cuda11_3 branch 3 times, most recently from 4bbc300 to 5c7089d Compare October 3, 2025 01:54
@cyyever cyyever marked this pull request as ready for review October 3, 2025 01:55
@cyyever cyyever force-pushed the cleanup_cuda11_3 branch 2 times, most recently from e01e4c3 to df13c13 Compare October 3, 2025 03:25
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever cyyever requested a review from eqy October 3, 2025 04:26
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Copy link
Collaborator

@eqy eqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, may need eyes from hip/rocm side as I don't know details there

@eqy eqy requested a review from jeffdaily October 3, 2025 14:50
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 4, 2025

ROCm is not touched much, let's try it.

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 4, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2025
@cyyever cyyever added the ciflow/rocm Trigger "default" config CI on ROCm label Oct 4, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever added a commit to cyyever/pytorch that referenced this pull request Oct 4, 2025
This PR removes outdated CUDA version checks from sparse code in aten/src/ATen/cuda.

Pull Request resolved: pytorch#164531
Approved by: https://github.com/eqy
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
This PR removes outdated CUDA version checks from sparse code in aten/src/ATen/cuda.

Pull Request resolved: pytorch#164531
Approved by: https://github.com/eqy
@cyyever cyyever deleted the cleanup_cuda11_3 branch October 28, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: sparse release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants