Skip to content

Make sure Windows CUDA 12.8 build follow same arches as Linux builds#164470

Closed
atalman wants to merge 1 commit intomainfrom
atalman-patch-6
Closed

Make sure Windows CUDA 12.8 build follow same arches as Linux builds#164470
atalman wants to merge 1 commit intomainfrom
atalman-patch-6

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Oct 2, 2025 •
edited
Loading

I believe set TORCH_CUDA_ARCH_LIST=7.0;7.5;8.0;8.6;9.0;10.0;12.0 is the one thats actually used. Hence remove 6.1 to align the support with Linux support.

@atalman atalman requested a review from a team as a code owner October 2, 2025 14:45
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164470

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 4b7b868 with merge base bac0f28 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman added the topic: not user facing topic category label Oct 2, 2025
@atalman
Copy link
Contributor Author

atalman commented Oct 2, 2025

@pytorchmergebot merge -f "need to merge this one"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author

atalman commented Oct 2, 2025

@pytorchbot cherry-pick --onto release/2.9 --fixes "CD fix" -c critical

pytorchbot pushed a commit that referenced this pull request Oct 2, 2025
@atalman @pytorchbot
Make sure Windows CUDA 12.8 build follow same arches as Linux builds (#…
e64b191 
…164470)

I believe ``set TORCH_CUDA_ARCH_LIST=7.0;7.5;8.0;8.6;9.0;10.0;12.0`` is the one thats actually used. Hence remove 6.1  to align the support with Linux support.
Pull Request resolved: #164470
Approved by: https://github.com/tinglvv, https://github.com/nWEIdia, https://github.com/Camyll

(cherry picked from commit 235b995)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Oct 2, 2025

Cherry picking #164470

The cherry pick PR is at #164477 and it is linked with issue CD fix. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 2, 2025
Closed
atalman added a commit that referenced this pull request Oct 2, 2025
@pytorchbot @atalman
Make sure Windows CUDA 12.8 build follow same arches as Linux builds (#…
d6e8411 
…164477)

Make sure Windows CUDA 12.8 build follow same arches as Linux builds (#164470)

I believe ``set TORCH_CUDA_ARCH_LIST=7.0;7.5;8.0;8.6;9.0;10.0;12.0`` is the one thats actually used. Hence remove 6.1  to align the support with Linux support.
Pull Request resolved: #164470
Approved by: https://github.com/tinglvv, https://github.com/nWEIdia, https://github.com/Camyll

(cherry picked from commit 235b995)

Co-authored-by: Andrey Talman <atalman@fb.com>
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@atalman @Chao1Han
Make sure Windows CUDA 12.8 build follow same arches as Linux builds (p…
0b47332 
…ytorch#164470)

I believe ``set TORCH_CUDA_ARCH_LIST=7.0;7.5;8.0;8.6;9.0;10.0;12.0`` is the one thats actually used. Hence remove 6.1  to align the support with Linux support.
Pull Request resolved: pytorch#164470
Approved by: https://github.com/tinglvv, https://github.com/nWEIdia, https://github.com/Camyll
@github-actions github-actions bot deleted the atalman-patch-6 branch November 2, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tinglvv tinglvv tinglvv approved these changes

@nWEIdia nWEIdia nWEIdia approved these changes

+1 more reviewer

@Camyll Camyll Camyll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@atalman @pytorchmergebot @pytorchbot @Camyll @tinglvv @nWEIdia