[ROCm] Improve non stride-one backwards indexing for small index sets#164409
Closed
doru1004 wants to merge 1 commit intopytorch:mainfrom
Closed
[ROCm] Improve non stride-one backwards indexing for small index sets#164409doru1004 wants to merge 1 commit intopytorch:mainfrom
doru1004 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164409
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0da9449 with merge base 59a86cb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: rocm
mikaylagawarecki
added
the
triaged
jerrymannil
reviewed
Oct 7, 2025
doru1004
force-pushed
the
fix-index-backwards-perf
branch
from
add600a to
0da9449
Compare
jerrymannil
approved these changes
Oct 7, 2025
jeffdaily
added
release notes: rocm
jerrymannil
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 8, 2025
jeffdaily
approved these changes
Oct 8, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rocm-repo-management-api bot
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 9, 2025
rocm-repo-management-api bot
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 10, 2025
rocm-repo-management-api bot
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 16, 2025
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…pytorch#164409) This patch fixes a performance problem which occurs when a small set of indices is used and there are practically no duplicates. Pull Request resolved: pytorch#164409 Approved by: https://github.com/jerrymannil, https://github.com/jeffdaily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a performance problem which occurs when a small set of indices is used and there are practically no duplicates.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd