Skip to content

[CD][CUDA13][NCCL] Fix nccl version typo for cu13 #164383

Closed
nWEIdia wants to merge 1 commit intomainfrom
main-cu13-fix-nccl-version
Closed

[CD][CUDA13][NCCL] Fix nccl version typo for cu13 #164383
nWEIdia wants to merge 1 commit intomainfrom
main-cu13-fix-nccl-version

Conversation

@nWEIdia
Copy link
Collaborator

@nWEIdia nWEIdia commented Oct 1, 2025

https://pypi.org/project/nvidia-nccl-cu13/#history does not have 2.27.5 but 2.27.7+.
Companion PR: #164352

Fixes a potential binary breakage due to non-existence of referenced NCCL cu13 version.

cc @ptrblck @eqy @tinglvv @atalman @malfet @albanD @ngimel

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164383

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 129 Pending

As of commit dbf9357 with merge base f63d16c (image):

NEW FAILURES - The following jobs have failed:

  • windows-binary-wheel / wheel-py3_14-cpu-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\.ci\pytorch\windows\Python\include\internal/pycore_interpframe.h(313): error C7555: use of designated initializers requires at least '/std:c++20'
  • windows-binary-wheel / wheel-py3_14t-cpu-build (gh)
    C:\actions-runner\_work\pytorch\pytorch\pytorch\.ci\pytorch\windows\Python\include\internal/pycore_interpframe.h(313): error C7555: use of designated initializers requires at least '/std:c++20'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nWEIdia nWEIdia changed the title [CD][CU13][NCCL] Fix nccl version typo for cu13 [CD][CUDA13][NCCL] Fix nccl version typo for cu13 Oct 1, 2025
@nWEIdia nWEIdia added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Oct 1, 2025
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: windows-binary-wheel / wheel-py3_14-cpu-build

Details for Dev Infra team Raised by workflow job

@tinglvv
Copy link
Collaborator

tinglvv commented Oct 1, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: windows-binary-wheel / wheel-py3_14t-cpu-build, windows-binary-wheel / wheel-py3_14-cpu-build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@nWEIdia
Copy link
Collaborator Author

nWEIdia commented Oct 1, 2025

Thanks @tinglvv .
We can ignore the windows failures because they are broken in trunk (nightly), see https://github.com/pytorch/pytorch/actions/runs/18154980794/job/51672724261

@atalman
Copy link
Contributor

atalman commented Oct 1, 2025

@pytorchmergebot merge -f "All looks good"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@atalman
Copy link
Contributor

atalman commented Oct 1, 2025

@pytorchmergebot merge -f "All looks good"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@nWEIdia nWEIdia deleted the main-cu13-fix-nccl-version branch October 2, 2025 17:13
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
https://pypi.org/project/nvidia-nccl-cu13/#history does not have 2.27.5 but 2.27.7+.
Companion PR: pytorch#164352

Fixes a potential binary breakage due to non-existence of referenced NCCL cu13 version.

Pull Request resolved: pytorch#164383
Approved by: https://github.com/tinglvv, https://github.com/Skylion007, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants