Closed
Conversation
Fixes pytorch#164271. Carveout had been applied with an opposite bitmask. Besides being incorrect, this lead to flaky unit test behavior due to carveout being too high.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164303
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 062f6f5 with merge base 07d896f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
approved these changes
Sep 30, 2025
jeffdaily
added
ciflow/trunk
jeffdaily
approved these changes
Sep 30, 2025
pytorch-bot
bot
removed
ciflow/trunk
jeffdaily
added
ciflow/trunk
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Oct 7, 2025
Fixes pytorch#164271. Carveout had been applied with an opposite bitmask. Besides being incorrect, this lead to flaky unit test behavior due to carveout being too high. Pull Request resolved: pytorch#164303 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Oct 7, 2025
Fixes pytorch#164271. Carveout had been applied with an opposite bitmask. Besides being incorrect, this lead to flaky unit test behavior due to carveout being too high. Pull Request resolved: pytorch#164303 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Oct 8, 2025
Fixes pytorch#164271. Carveout had been applied with an opposite bitmask. Besides being incorrect, this lead to flaky unit test behavior due to carveout being too high. Pull Request resolved: pytorch#164303 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 8, 2025
This includes both the initial carveout PR plus it's later fix. - initial PR pytorch#149466 - fix PR pytorch#164303
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Fixes pytorch#164271. Carveout had been applied with an opposite bitmask. Besides being incorrect, this lead to flaky unit test behavior due to carveout being too high. Pull Request resolved: pytorch#164303 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164271.
Carveout had been applied with an opposite bitmask. Besides being incorrect, this lead to flaky unit test behavior due to carveout being too high.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd