Skip to content

Add Rocm to Operator Microbenchmark CI#164173

Closed
jainapurva wants to merge 7 commits intomainfrom
rocm_op_bench
Closed

Add Rocm to Operator Microbenchmark CI#164173
jainapurva wants to merge 7 commits intomainfrom
rocm_op_bench

Conversation

@jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Sep 29, 2025 •
edited by pytorch-bot bot
Loading

This pull request adds support for running operator microbenchmarks on ROCm (AMD GPU) environments in the CI workflow. The main changes involve introducing new build and test jobs for ROCm in the .github/workflows/operator_microbenchmark.yml file.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164173

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 12 Pending, 2 Unrelated Failures

As of commit 923822b with merge base 5dbae1e (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Sep 29, 2025
@jainapurva
Add b200
1bd7e25
@jainapurva
Update operator_microbenchmark workflow
19fec20 
Removed pull request triggers and B200 runner configurations.
@jainapurva jainapurva added the ciflow/op-benchmark Trigger microbenchmark for operations. label Sep 30, 2025
@jainapurva jainapurva changed the title Add CI workflow for Rocm for Operator Microbenchmark Add Rocm to Operator Microbenchmark CI Sep 30, 2025
@jainapurva jainapurva marked this pull request as ready for review October 1, 2025 18:54
@jainapurva jainapurva requested a review from a team as a code owner October 1, 2025 18:54
huydhn
huydhn approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes, so LGTM!

@huydhn
Copy link
Contributor

huydhn commented Oct 1, 2025

We need a rebase to avoid the clash with #164288

@jainapurva
<Replace this line with a title. Use 1 line only, 67 chars or less>
3662a01 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@jainapurva
updates
923822b
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2025
@huydhn huydhn removed the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2025
@huydhn
Copy link
Contributor

huydhn commented Oct 3, 2025

@pytorchbot merge -f 'Ops micro benchmark on ROCm has passed'

https://github.com/pytorch/pytorch/actions/runs/18182242863/job/51839016840?pr=164173

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 3, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@jainapurva @Chao1Han
Add Rocm to Operator Microbenchmark CI (pytorch#164173)
0feb29d 
This pull request adds support for running operator microbenchmarks on ROCm (AMD GPU) environments in the CI workflow. The main changes involve introducing new build and test jobs for ROCm in the `.github/workflows/operator_microbenchmark.yml` file.

Pull Request resolved: pytorch#164173
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the rocm_op_bench branch November 3, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees

No one assigned

Labels

ciflow/op-benchmark Trigger microbenchmark for operations. ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jainapurva @huydhn @pytorchmergebot