[PP] Use default export mode (non-strict)#164045
[PP] Use default export mode (non-strict)#164045kwen2501 wants to merge 1 commit intogh/kwen2501/267/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164045
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit eb80ad6 with merge base 8d81564 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
oncall: distributed
kwen2501
added
module: pipelining
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f "last merge timed out" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #164030: HOP and pipelining both name things submod_i by adding an optional argument `partition_affix` to `split_module` API. Pull Request resolved: #164035 Approved by: https://github.com/ezyang ghstack dependencies: #164045
Changing PP submodules' name from `submod_i` to `submod_pp_i` to distinguish from the submodule created by HOP. Pull Request resolved: #164037 Approved by: https://github.com/H-Huang ghstack dependencies: #164045, #164035
Fixes #164030: HOP and pipelining both name things submod_i by adding an optional argument `partition_affix` to `split_module` API. Pull Request resolved: #164035 Approved by: https://github.com/ezyang ghstack dependencies: #164045
Changing PP submodules' name from `submod_i` to `submod_pp_i` to distinguish from the submodule created by HOP. Pull Request resolved: #164037 Approved by: https://github.com/H-Huang ghstack dependencies: #164045, #164035
Fixes pytorch#164030: HOP and pipelining both name things submod_i by adding an optional argument `partition_affix` to `split_module` API. Pull Request resolved: pytorch#164035 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#164045
Changing PP submodules' name from `submod_i` to `submod_pp_i` to distinguish from the submodule created by HOP. Pull Request resolved: pytorch#164037 Approved by: https://github.com/H-Huang ghstack dependencies: pytorch#164045, pytorch#164035
ghstack-source-id: 1ea2c35 Pull-Request: pytorch/pytorch#164045
3 participants
Stack from ghstack (oldest at bottom):
export's default mode has switched from strict to non-strict. We just follow suit in PP.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci