[ROCm] use hipSolver instead of MAGMA for Cholesky#163977
Closed
afanfa wants to merge 1 commit intopytorch:mainfrom
Closed
[ROCm] use hipSolver instead of MAGMA for Cholesky#163977afanfa wants to merge 1 commit intopytorch:mainfrom
afanfa wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163977
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c863c29 with merge base 9534c59 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The committers listed above are authorized under a signed CLA. |
jeffdaily
changed the title
jeffdaily
added
release notes: rocm
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pytorch-bot
bot
removed
ciflow/rocm
jeffdaily
added
ciflow/rocm
Skylion007
approved these changes
Sep 27, 2025
Collaborator
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Currently, the Cholesky factorization and least squares operation defaults to magma when Pytorch is compiled for ROCm. This shows suboptimal performance. This change allows PyTorch to rely on hipSolver instead of Magma. @jeffdaily Pull Request resolved: #163977 Approved by: https://github.com/Skylion007
maggiemoss
pushed a commit
to maggiemoss/pytorch
that referenced
this pull request
Sep 29, 2025
Currently, the Cholesky factorization and least squares operation defaults to magma when Pytorch is compiled for ROCm. This shows suboptimal performance. This change allows PyTorch to rely on hipSolver instead of Magma. @jeffdaily Pull Request resolved: pytorch#163977 Approved by: https://github.com/Skylion007
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 2, 2026
Currently, the Cholesky factorization and least squares operation defaults to magma when Pytorch is compiled for ROCm. This shows suboptimal performance. This change allows PyTorch to rely on hipSolver instead of Magma. @jeffdaily Pull Request resolved: pytorch#163977 Approved by: https://github.com/Skylion007 (cherry picked from commit 238dc65)
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 2, 2026
Currently, the Cholesky factorization and least squares operation defaults to magma when Pytorch is compiled for ROCm. This shows suboptimal performance. This change allows PyTorch to rely on hipSolver instead of Magma. @jeffdaily Pull Request resolved: pytorch#163977 Approved by: https://github.com/Skylion007 (cherry picked from commit 238dc65)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Cholesky factorization and least squares operation defaults to magma when Pytorch is compiled for ROCm. This shows suboptimal performance.
This change allows PyTorch to rely on hipSolver instead of Magma.
@jeffdaily
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd