[DeviceMesh][ez] Add a type alias for backend config#163928
Closed
fduwjj wants to merge 1 commit intogh/fduwjj/209/basefrom
Closed
[DeviceMesh][ez] Add a type alias for backend config#163928fduwjj wants to merge 1 commit intogh/fduwjj/209/basefrom
fduwjj wants to merge 1 commit intogh/fduwjj/209/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163928
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c19abda with merge base 5fcde74 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 26, 2025
fegin
approved these changes
Sep 26, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 26, 2025
This is just to extract common logic into a util function because we will use it many times for the following stack of Device Mesh refactoring. Pull Request resolved: #163930 Approved by: https://github.com/fegin ghstack dependencies: #163212, #163288, #163928
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 27, 2025
) While refactoring the bookkeeping for DeviceMesh while leveraging CuTe layout, we found that we need to have two more util functions. One is to check whether one layout has overlap inside it or not. For example, (2,2):(2:1) has no overlap while (2,2):(2:2) has overlap. Pull Request resolved: #163367 Approved by: https://github.com/fegin ghstack dependencies: #163212, #163288, #163928, #163930
This was referenced Sep 26, 2025
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Create a type alias for `tuple[Optional[str], Optional[C10dBackend.Options]]` since it is too long. Pull Request resolved: #163928 Approved by: https://github.com/fegin ghstack dependencies: #163212, #163288
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
This is just to extract common logic into a util function because we will use it many times for the following stack of Device Mesh refactoring. Pull Request resolved: #163930 Approved by: https://github.com/fegin ghstack dependencies: #163212, #163288, #163928
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
) While refactoring the bookkeeping for DeviceMesh while leveraging CuTe layout, we found that we need to have two more util functions. One is to check whether one layout has overlap inside it or not. For example, (2,2):(2:1) has no overlap while (2,2):(2:2) has overlap. Pull Request resolved: #163367 Approved by: https://github.com/fegin ghstack dependencies: #163212, #163288, #163928, #163930
maggiemoss
pushed a commit
to maggiemoss/pytorch
that referenced
this pull request
Sep 29, 2025
…163930) This is just to extract common logic into a util function because we will use it many times for the following stack of Device Mesh refactoring. Pull Request resolved: pytorch#163930 Approved by: https://github.com/fegin ghstack dependencies: pytorch#163212, pytorch#163288, pytorch#163928
maggiemoss
pushed a commit
to maggiemoss/pytorch
that referenced
this pull request
Sep 29, 2025
…rch#163367) While refactoring the bookkeeping for DeviceMesh while leveraging CuTe layout, we found that we need to have two more util functions. One is to check whether one layout has overlap inside it or not. For example, (2,2):(2:1) has no overlap while (2,2):(2:2) has overlap. Pull Request resolved: pytorch#163367 Approved by: https://github.com/fegin ghstack dependencies: pytorch#163212, pytorch#163288, pytorch#163928, pytorch#163930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Create a type alias for
tuple[Optional[str], Optional[C10dBackend.Options]]since it is too long.cc @H-Huang @awgu @wanchaol @fegin @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci