Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163879
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 113cdd7 with merge base c4312b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
XilunWu
approved these changes
Sep 25, 2025
Comment on lines
+1240
to
+1246
| schema_info=RuntimeSchemaInfo( | ||
| # static_argnum is the position where non-Tensor args beings. | ||
| static_argnum=1, | ||
| # static_kwargkey is the name of kwargs to hash (which determines | ||
| # whether sharding prop can be cached). | ||
| static_kwargkey=["keepdim"], | ||
| ), |
|
|
||
| # args_schema contains all but the DTensor args (e.g., dim, keepdim). | ||
| args_schema = op_schema.args_schema | ||
| assert len(args_schema) > 1 # input and dim are required. |
Contributor
There was a problem hiding this comment.
assert len(args_schema) == 2?
Contributor
|
Does DTensor provide an easy way to register reduction ops regardless of their varying arguments? i.e. extract the argument processing part. |
Member
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
as title, mostly copypasta from internal. I am a dtensor noob, so please scrutinize my added test. Pull Request resolved: #163879 Approved by: https://github.com/XilunWu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as title, mostly copypasta from internal. I am a dtensor noob, so please scrutinize my added test.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim @dcci