[Inductor] add a new config fallback_embedding_bag_byte_unpack#163803
Closed
hl475 wants to merge 1 commit intopytorch:mainfrom
Closed
[Inductor] add a new config fallback_embedding_bag_byte_unpack#163803hl475 wants to merge 1 commit intopytorch:mainfrom
hl475 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163803
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5be8a4b with merge base c4312b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 24, 2025
…ch#163803) Summary: Pull Request resolved: pytorch#163803 Differential Revision: D82988783
hl475
force-pushed
the
export-D82988783
branch
from
558db5f to
22ed0f3
Compare
Contributor
hl475
force-pushed
the
export-D82988783
branch
from
22ed0f3 to
ee60f38
Compare
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 25, 2025
…ch#163803) Summary: introduce an inductor config fallback_embedding_bag_byte_unpack so we can have options to not let inductor decompose the op Differential Revision: D82988783
Contributor
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 25, 2025
…ch#163803) Summary: introduce an inductor config fallback_embedding_bag_byte_unpack so we can have options to not let inductor decompose the op Reviewed By: henryoier Differential Revision: D82988783
hl475
force-pushed
the
export-D82988783
branch
from
ee60f38 to
b024891
Compare
Contributor
hl475
force-pushed
the
export-D82988783
branch
from
b024891 to
7fdfe8c
Compare
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 25, 2025
…ch#163803) Summary: introduce an inductor config fallback_embedding_bag_byte_unpack so we can have options to not let inductor decompose the op Reviewed By: henryoier Differential Revision: D82988783
Contributor
henryoier
approved these changes
Sep 25, 2025
hl475
force-pushed
the
export-D82988783
branch
from
7fdfe8c to
eb2f1cc
Compare
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 25, 2025
…ch#163803) Summary: introduce an inductor config fallback_embedding_bag_byte_unpack so we can have options to not let inductor decompose the op Reviewed By: henryoier Differential Revision: D82988783
Contributor
…ch#163803) Summary: introduce an inductor config fallback_embedding_bag_byte_unpack so we can have options to not let inductor decompose the op Reviewed By: henryoier Differential Revision: D82988783
hl475
force-pushed
the
export-D82988783
branch
from
eb2f1cc to
5be8a4b
Compare
Contributor
desertfire
reviewed
Sep 25, 2025
| """decomps can change based on config""" | ||
| if config.fallback_random: | ||
| return decompositions | ||
| if config.fallback_embedding_bag_byte_unpack is True: |
Contributor
There was a problem hiding this comment.
Nit: if config.fallback_embedding_bag_byte_unpack:
Comment on lines
+890
to
+893
| for k in decompositions.keys(): | ||
| if k == torch.ops.quantized.embedding_bag_byte_unpack.default: | ||
| del decompositions[k] | ||
| break |
Contributor
There was a problem hiding this comment.
decompositions.pop(torch.ops.quantized.embedding_bag_byte_unpack.default, None)
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
Author
|
sorry @desertfire , just saw the comments. will submit another diff/PR to address your comments! |
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 25, 2025
Summary: address comments from pytorch#163803 Differential Revision: D83291637
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 25, 2025
Summary: address comments from pytorch#163803 Differential Revision: D83291637
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 26, 2025
Summary: address comments from pytorch#163803 Differential Revision: D83291637
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 26, 2025
Summary: address comments from pytorch#163803 Differential Revision: D83291637
hl475
added a commit
to hl475/pytorch
that referenced
this pull request
Sep 26, 2025
Summary: address comments from pytorch#163803 Differential Revision: D83291637
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 26, 2025
Summary: address comments from #163803 Differential Revision: D83291637 Pull Request resolved: #163901 Approved by: https://github.com/desertfire
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Differential Revision: D82988783 introduce an inductor config fallback_embedding_bag_byte_unpack so we can have options to not let inductor decompose the op Pull Request resolved: #163803 Approved by: https://github.com/henryoier
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Summary: address comments from #163803 Differential Revision: D83291637 Pull Request resolved: #163901 Approved by: https://github.com/desertfire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D82988783
introduce an inductor config fallback_embedding_bag_byte_unpack so we can have options to not let inductor decompose the op
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben