Skip to content

[ROCm][CI] cudagraph trees ut fixes#163592

Closed
xinyazhang wants to merge 4 commits intopytorch:mainfrom
ROCm:rocm_cudagraph_trees_ut_fixes
Closed

[ROCm][CI] cudagraph trees ut fixes#163592
xinyazhang wants to merge 4 commits intopytorch:mainfrom
ROCm:rocm_cudagraph_trees_ut_fixes

Conversation

@xinyazhang
Copy link
Collaborator

@xinyazhang xinyazhang commented Sep 23, 2025

Use @torch._inductor.config.patch("triton.cudagraph_capture_sizes")
instead of permanently changing the setting for all tests.
test would fail depending on the self.device_idx that was randomly set
during CudaGraphTreeTests.setUp(self).
test assumed device 0 and would fail if self.device_idx was non-zero
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163592

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2f1161a with merge base 232dd65 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm module: inductor labels Sep 23, 2025
@facebook-github-bot facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Sep 23, 2025
@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Sep 23, 2025
@jeffdaily jeffdaily changed the title Rocm cudagraph trees ut fixes [ROCm][CI] cudagraph trees ut fixes Sep 23, 2025
@jeffdaily jeffdaily marked this pull request as ready for review September 23, 2025 00:31
@jeffdaily jeffdaily added the ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 label Sep 23, 2025
@pytorch-bot pytorch-bot bot removed ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 23, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 23, 2025
@jeffdaily
Copy link
Collaborator

@pytorchbot merge -f "we need cudagraph_trees UT stability, not waiting for additional CI"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment