[BUG] MaxUnpool2d/3d should check output dim before accessing its elements#163507
Closed
can-gaa-hou wants to merge 1 commit intopytorch:mainfrom
Closed
[BUG] MaxUnpool2d/3d should check output dim before accessing its elements#163507can-gaa-hou wants to merge 1 commit intopytorch:mainfrom
can-gaa-hou wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163507
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1345ff2 with merge base edafc90 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
can-gaa-hou
force-pushed
the
maxunpool
branch
from
9177e9f to
1345ff2
Compare
can-gaa-hou
requested review from
eqy,
kulinseth,
malfet and
syed-ahmed
as code owners
eqy
reviewed
Sep 22, 2025
|
|
||
| int64_t oT = output_size[0]; | ||
| int64_t oH = output_size[1]; | ||
| int64_t oW = output_size[2]; |
Collaborator
There was a problem hiding this comment.
What is the purpose of moving the declarations around?
Contributor
There was a problem hiding this comment.
Don't dereference 2nd index of output_size if output_size.length() is 0 or something (which I guess is validated by next TORCH_CHECK)
malfet
approved these changes
Sep 22, 2025
malfet
changed the title
Skylion007
approved these changes
Sep 22, 2025
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
janeyx99
added
the
triaged
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…ments (pytorch#163507) Fixes pytorch#163409 Pull Request resolved: pytorch#163507 Approved by: https://github.com/malfet, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163409