[BC breaking] Remove deprecated imports for torch.utils.data.datapipes.iter.grouping#163438
[BC breaking] Remove deprecated imports for torch.utils.data.datapipes.iter.grouping#163438cyyever wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163438
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit a939d99 with merge base 3a7db34 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cyyever
force-pushed
the
remove_deprecated2
branch
from
0e5efa8 to
03a4908
Compare
janeyx99
left a comment
janeyx99
left a comment
There was a problem hiding this comment.
Nice, but please write up a BC breaking note in the PR Description similar to in https://docs.google.com/document/d/14OmgGBr1w6gl1VO47GGGdwrIaUNr92DFhQbY_NEk8mQ/edit?tab=t.0#heading=h.xhn730wluw68
|
@janeyx99 I have no permission to open the google doc. |
cyyever
changed the title
cyyever
changed the title
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
|
Successfully rebased |
pytorchmergebot
force-pushed
the
remove_deprecated2
branch
from
03a4908 to
a939d99
Compare
|
@pytorchmergebot merge -f "Pending ROCm tests" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…s.iter.grouping (pytorch#163438) This PR removes import tricks of `SHARDING_PRIORITIES` and `ShardingFilterIterDataPipe` from `torch.utils.data.datapipes.iter.grouping`. They are declared to be removed in PyTorch 2.1 but not. Before change: ``` import torch.utils.data.datapipes.iter.grouping.SHARDING_PRIORITIES import torch.utils.data.datapipes.iter.grouping.ShardingFilterIterDataPipe ``` works After change: there is an import error exception. Pull Request resolved: pytorch#163438 Approved by: https://github.com/janeyx99
4 participants
This PR removes import tricks of
SHARDING_PRIORITIESandShardingFilterIterDataPipefromtorch.utils.data.datapipes.iter.grouping. They are declared to be removed in PyTorch 2.1 but not.Before change:
works
After change:
there is an import error exception.