[BE][Ez]: Prevent copies of std::vector in CUDA ForeachOps#163416
Closed
Skylion007 wants to merge 2 commits intopytorch:mainfrom
Closed
[BE][Ez]: Prevent copies of std::vector in CUDA ForeachOps#163416Skylion007 wants to merge 2 commits intopytorch:mainfrom
Skylion007 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163416
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 502e3cf with merge base d70c0ba ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
changed the title
Skylion007
changed the title
Skylion007
added
the
better-engineering
ezyang
approved these changes
Sep 21, 2025
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…63416) No need for unnecessary copy of std::vectors. This Tensor list is copied throughout the foreach paths and this code is on a hot path for torch optimizers. Auto move elision will not happen on the return statement since it's a subelement of a vector that needs to be copied out before the std::vector is dtor'd. This should reduce quite a few list copies along this path. Pull Request resolved: pytorch#163416 Approved by: https://github.com/ezyang
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…63416) No need for unnecessary copy of std::vectors. This Tensor list is copied throughout the foreach paths and this code is on a hot path for torch optimizers. Auto move elision will not happen on the return statement since it's a subelement of a vector that needs to be copied out before the std::vector is dtor'd. This should reduce quite a few list copies along this path. Pull Request resolved: pytorch#163416 Approved by: https://github.com/ezyang
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 22, 2025
@ezyang A follow up where I found a few more missing returns of this style in the codebase. Follow up to #163416 Pull Request resolved: #163456 Approved by: https://github.com/cyyever, https://github.com/albanD
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…63416) No need for unnecessary copy of std::vectors. This Tensor list is copied throughout the foreach paths and this code is on a hot path for torch optimizers. Auto move elision will not happen on the return statement since it's a subelement of a vector that needs to be copied out before the std::vector is dtor'd. This should reduce quite a few list copies along this path. Pull Request resolved: pytorch#163416 Approved by: https://github.com/ezyang
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
@ezyang A follow up where I found a few more missing returns of this style in the codebase. Follow up to pytorch#163416 Pull Request resolved: pytorch#163456 Approved by: https://github.com/cyyever, https://github.com/albanD
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2025
inspired by #163416 Pull Request resolved: #163599 Approved by: https://github.com/Skylion007
pytorch-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
inspired by #163416 Pull Request resolved: #163599 Approved by: https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need for unnecessary copy of std::vectors. This Tensor list is copied throughout the foreach paths and this code is on a hot path for torch optimizers. Auto move elision will not happen on the return statement since it's a subelement of a vector that needs to be copied out before the std::vector is dtor'd. This should reduce quite a few list copies along this path.