Skip to content

[inductor] Fix bug where viewed outputs get padded#163398

Closed
jansel wants to merge 5 commits intogh/jansel/537/basefrom
gh/jansel/537/head
Closed

[inductor] Fix bug where viewed outputs get padded#163398
jansel wants to merge 5 commits intogh/jansel/537/basefrom
gh/jansel/537/head

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Sep 20, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes #163328

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@jansel
Update
35a4435 
[ghstack-poisoned]
@jansel jansel mentioned this pull request Sep 20, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163398

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 75235f2 with merge base 51152ef (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jansel added a commit that referenced this pull request Sep 20, 2025
@jansel
[inductor] Fix bug where viewed outputs get padded
9343aab 
Fixes #163328


ghstack-source-id: 41f1f13
Pull-Request: #163398
This was referenced Sep 20, 2025
Closed
Closed
@jansel jansel mentioned this pull request Sep 20, 2025
Closed
@jansel jansel added the topic: not user facing topic category label Sep 20, 2025
@jansel jansel requested a review from yifuwang September 20, 2025 04:01
@jansel
Update
a085b94 
[ghstack-poisoned]
@jansel jansel requested a review from eellison September 20, 2025 15:23
This was referenced Sep 20, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@jansel
Update
a7ee7fa 
[ghstack-poisoned]
@jansel
Update
2dfb84e 
[ghstack-poisoned]
This was referenced Sep 22, 2025
Closed
Closed
@jansel jansel mentioned this pull request Sep 22, 2025
Closed
@jansel
Update
75235f2 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 22, 2025

Starting merge as part of PR stack under #163434

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 22, 2025

Starting merge as part of PR stack under #163415

pytorchmergebot pushed a commit that referenced this pull request Sep 22, 2025
@jansel @pytorchmergebot
[inductor] Skip test_baddmm on XPU (#163414)
c8fd2b4 
Fixes #161484
Pull Request resolved: #163414
Approved by: https://github.com/Skylion007
ghstack dependencies: #163386, #163398, #163387
pytorchmergebot pushed a commit that referenced this pull request Sep 22, 2025
@jansel @pytorchmergebot
[inductor] Don't require_dense for grid_sampler_2d_backward (#163415)
4fc271e 
Fixes #163372

Pull Request resolved: #163415
Approved by: https://github.com/Skylion007
ghstack dependencies: #163386, #163398, #163387, #163414
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[inductor] libdevice.sqrt => tl.sqrt_rn (#163419)
518c320 
Fixes #163082

Pull Request resolved: #163419
Approved by: https://github.com/Skylion007, https://github.com/mlazos
ghstack dependencies: #163386, #163398, #163387, #163414, #163415
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[inductor] Freeze layouts in FlexAttention (#163434)
ed84e80 
Fixes #163300

Pull Request resolved: #163434
Approved by: https://github.com/drisspg
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[inductor] Support out_dtype arg to matmul (#163393)
9c4d9f9 
Fixes #163275

Pull Request resolved: #163393
Approved by: https://github.com/eellison, https://github.com/coconutruben
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[dynamo] Fix TorchFunctionMode handling with get_rng_state (#163412)
6ef7487 
Fixes #162624
Fixes #162586

Pull Request resolved: #163412
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393
pytorchmergebot pushed a commit that referenced this pull request Sep 23, 2025
@jansel @pytorchmergebot
[inductor] Fix error from custom CUDA allocators (#163422)
49e7b2f 
Fixes #163257

Pull Request resolved: #163422
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
[inductor] Fix issue with scalar arg handling (#163481)
ca512af 
Fixes #163420

Pull Request resolved: #163481
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
[inductor] Fix bugs in emulate_precision_casts (#163520)
6fa9727 
Fixes #163449
Pull Request resolved: #163520
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
[inductor] Fix divmod error in decomp (#163482)
d746b98 
Fixes #163457

Pull Request resolved: #163482
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520
pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2025
@jansel @pytorchmergebot
Revert "[inductor] Fix issue with scalar arg handling" (#163737)
3e1b1a3 
This reverts commit a8cd437.

See #163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: #163737
Approved by: https://github.com/ezyang
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix bug where viewed outputs get padded (pytorch#163398)
df7176d 
Fixes pytorch#163328

Pull Request resolved: pytorch#163398
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fallback on strided complex add (pytorch#163387)
11b3859 
Fixes pytorch#163243
Fixes pytorch#162561

Pull Request resolved: pytorch#163387
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Skip test_baddmm on XPU (pytorch#163414)
7a27472 
Fixes pytorch#161484
Pull Request resolved: pytorch#163414
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Don't require_dense for grid_sampler_2d_backward (pytorch#…
e038c4d 
…163415)

Fixes pytorch#163372

Pull Request resolved: pytorch#163415
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] libdevice.sqrt => tl.sqrt_rn (pytorch#163419)
4c1969e 
Fixes pytorch#163082

Pull Request resolved: pytorch#163419
Approved by: https://github.com/Skylion007, https://github.com/mlazos
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Freeze layouts in FlexAttention (pytorch#163434)
1fc5e2b 
Fixes pytorch#163300

Pull Request resolved: pytorch#163434
Approved by: https://github.com/drisspg
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Support out_dtype arg to matmul (pytorch#163393)
642eee2 
Fixes pytorch#163275

Pull Request resolved: pytorch#163393
Approved by: https://github.com/eellison, https://github.com/coconutruben
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[dynamo] Fix TorchFunctionMode handling with get_rng_state (pytorch#1…
2cbaddb 
…63412)

Fixes pytorch#162624
Fixes pytorch#162586

Pull Request resolved: pytorch#163412
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix error from custom CUDA allocators (pytorch#163422)
f3d9ff8 
Fixes pytorch#163257

Pull Request resolved: pytorch#163422
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix issue with scalar arg handling (pytorch#163481)
e8e41d6 
Fixes pytorch#163420

Pull Request resolved: pytorch#163481
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix bugs in emulate_precision_casts (pytorch#163520)
25d3d52 
Fixes pytorch#163449
Pull Request resolved: pytorch#163520
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
[inductor] Fix divmod error in decomp (pytorch#163482)
9a6a07f 
Fixes pytorch#163457

Pull Request resolved: pytorch#163482
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jansel @dsashidh
Revert "[inductor] Fix issue with scalar arg handling" (pytorch#163737)
be4de28 
This reverts commit a8cd437.

See pytorch#163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: pytorch#163737
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520, pytorch#163482
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
[inductor] Fix issue with scalar arg handling (#163481)
7fcb471 
Fixes #163420

Pull Request resolved: #163481
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
[inductor] Fix bugs in emulate_precision_casts (#163520)
0b4ce81 
Fixes #163449
Pull Request resolved: #163520
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
[inductor] Fix divmod error in decomp (#163482)
f424a19 
Fixes #163457

Pull Request resolved: #163482
Approved by: https://github.com/eellison
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520
jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@jansel @jainapurva
Revert "[inductor] Fix issue with scalar arg handling" (#163737)
cb2c05b 
This reverts commit a8cd437.

See #163481 (comment)

This PR might also cause issues with cudagraphs.

Pull Request resolved: #163737
Approved by: https://github.com/ezyang
ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482
@github-actions github-actions bot deleted the gh/jansel/537/head branch October 23, 2025 02:13
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@jansel
[inductor] Fix bug where viewed outputs get padded
25d17d8 
Fixes #163328


ghstack-source-id: 97b373e
Pull-Request: pytorch/pytorch#163398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@yifuwang yifuwang Awaiting requested review from yifuwang

Assignees

No one assigned

Labels

ciflow/inductor Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jansel @pytorchmergebot @eellison