[inductor] Support out_dtype arg to matmul by jansel · Pull Request #163393 · pytorch/pytorch

jansel · 2025-09-20T00:33:50Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos

[ghstack-poisoned]

pytorch-bot · 2025-09-20T00:33:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163393

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b799ad4 with merge base 51152ef ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

eellison

cc @coconutruben to review as well

eellison · 2025-09-22T13:03:36Z

torch/_inductor/kernel/mm.py

    Lowering for autotuning aten.mm with different backends (Aten, Triton, CUTLASS, etc.)
    """
+    if out_dtype is not None:
+        input_dtype = mat1.get_dtype()


nit: would expect kernel error checking to already occur in meta registration.

eellison · 2025-09-22T13:05:11Z

torch/_meta_registrations.py

@@ -2238,7 +2238,7 @@ def meta__fused_moving_avg_obs_fq_helper(

 @register_meta(aten.mm)
 @out_wrapper(exact_dtype=True)


is exact_dtype=True still correct ?

Not sure is this referring to matching the reference?

[ghstack-poisoned]

pytorchmergebot · 2025-09-23T04:26:38Z

Starting merge as part of PR stack under #163422

pytorchmergebot · 2025-09-23T15:36:37Z

Starting merge as part of PR stack under #163422

Fixes #162624 Fixes #162586 Pull Request resolved: #163412 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393

Fixes #163257 Pull Request resolved: #163422 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412

Fixes #163420 Pull Request resolved: #163481 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422

Fixes #163449 Pull Request resolved: #163520 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481

Fixes #163457 Pull Request resolved: #163482 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520

This reverts commit a8cd437. See #163481 (comment) This PR might also cause issues with cudagraphs. Pull Request resolved: #163737 Approved by: https://github.com/ezyang ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482

Fixes pytorch#163275 Pull Request resolved: pytorch#163393 Approved by: https://github.com/eellison, https://github.com/coconutruben ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434

…63412) Fixes pytorch#162624 Fixes pytorch#162586 Pull Request resolved: pytorch#163412 Approved by: https://github.com/eellison ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393

Fixes pytorch#163257 Pull Request resolved: pytorch#163422 Approved by: https://github.com/eellison ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412

Fixes pytorch#163420 Pull Request resolved: pytorch#163481 Approved by: https://github.com/eellison ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422

Fixes pytorch#163449 Pull Request resolved: pytorch#163520 Approved by: https://github.com/eellison ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481

Fixes pytorch#163457 Pull Request resolved: pytorch#163482 Approved by: https://github.com/eellison ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520

This reverts commit a8cd437. See pytorch#163481 (comment) This PR might also cause issues with cudagraphs. Pull Request resolved: pytorch#163737 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#163386, pytorch#163398, pytorch#163387, pytorch#163414, pytorch#163415, pytorch#163419, pytorch#163434, pytorch#163393, pytorch#163412, pytorch#163422, pytorch#163481, pytorch#163520, pytorch#163482

Fixes #163420 Pull Request resolved: #163481 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422

Fixes #163449 Pull Request resolved: #163520 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481

Fixes #163457 Pull Request resolved: #163482 Approved by: https://github.com/eellison ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520

This reverts commit a8cd437. See #163481 (comment) This PR might also cause issues with cudagraphs. Pull Request resolved: #163737 Approved by: https://github.com/ezyang ghstack dependencies: #163386, #163398, #163387, #163414, #163415, #163419, #163434, #163393, #163412, #163422, #163481, #163520, #163482

Fixes #163275 ghstack-source-id: 9fc01dd Pull-Request: pytorch/pytorch#163393

Update

01f35b4

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels Sep 20, 2025

This was referenced Sep 20, 2025

[dynamo] Fix issue with namedtuple slicing #163351

Closed

Better decomp for torch.eye #163386

Closed

[inductor] Fallback on strided complex add #163387

Closed

Fix prims.broadcast_in_dim functionalization #163377

Closed

jansel added the release notes: inductor label Sep 20, 2025

Update

c2a157e

[ghstack-poisoned]

jansel mentioned this pull request Sep 20, 2025

[inductor] Fix bug where viewed outputs get padded #163398

Closed

Update

67709b7

[ghstack-poisoned]

jansel requested a review from eellison September 20, 2025 15:23

jansel added 2 commits September 20, 2025 22:27

Update

53d105a

[ghstack-poisoned]

Update

bd360f1

[ghstack-poisoned]

This was referenced Sep 22, 2025

[inductor] Fix issue with scalar arg handling #163481

Closed

[inductor] Fix divmod error in decomp #163482

Closed

eellison approved these changes Sep 22, 2025

View reviewed changes

eellison requested a review from coconutruben September 22, 2025 13:06

jansel mentioned this pull request Sep 22, 2025

[inductor] Fix bugs in emulate_precision_casts #163520

Closed

jansel added 3 commits September 22, 2025 08:10

Update

a8fc488

[ghstack-poisoned]

Update

f37eb34

[ghstack-poisoned]

Update

b799ad4

[ghstack-poisoned]

coconutruben approved these changes Sep 22, 2025

View reviewed changes

jansel mentioned this pull request Sep 22, 2025

Update conv1d meta kernel to match eager #163584

Closed

pytorchmergebot added the Merged label Sep 23, 2025

pytorchmergebot closed this in 9c4d9f9 Sep 23, 2025

github-actions bot deleted the gh/jansel/536/head branch October 24, 2025 02:09

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025

[inductor] Support out_dtype arg to matmul

acde65b

Fixes #163275 ghstack-source-id: 9fc01dd Pull-Request: pytorch/pytorch#163393

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[inductor] Support out_dtype arg to matmul#163393

[inductor] Support out_dtype arg to matmul#163393
jansel wants to merge 8 commits intogh/jansel/536/basefrom
gh/jansel/536/head

jansel commented Sep 20, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 20, 2025 •

edited

Loading

Uh oh!

eellison left a comment

Uh oh!

eellison Sep 22, 2025

Uh oh!

eellison Sep 22, 2025

Uh oh!

jansel Sep 22, 2025

Uh oh!

pytorchmergebot commented Sep 23, 2025

Uh oh!

pytorchmergebot commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -2238,7 +2238,7 @@ def meta__fused_moving_avg_obs_fq_helper(

		@register_meta(aten.mm)
		@out_wrapper(exact_dtype=True)

Conversation

jansel commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163393

✅ No Failures

Uh oh!

eellison left a comment

Choose a reason for hiding this comment

Uh oh!

eellison Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

eellison Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

jansel Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Sep 23, 2025

Uh oh!

pytorchmergebot commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jansel commented Sep 20, 2025 •

edited

Loading

pytorch-bot bot commented Sep 20, 2025 •

edited

Loading