[inductor] fix as_strided lowering with .view(dtype) inputs#163319
[inductor] fix as_strided lowering with .view(dtype) inputs#163319xmfan wants to merge 4 commits intogh/xmfan/287/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163319
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 60cf911 with merge base 23af32a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
xmfan
changed the title
xmfan
changed the title
xmfan
changed the title
xmfan
changed the title
torch/_inductor/lowering.py
Outdated
| # its metadata. Except for device type and dtype, which we need | ||
| # to propagate. | ||
|
|
||
| # Technically device is not needed because it is handled as a copy | ||
| # instead of a view today. |
There was a problem hiding this comment.
Nit: Except for device type and dtype, which we need # to propagate.
rewrite this ? it's not possible to take cross-device views.
…inputs" FIXES #163286 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
xmfan
changed the title
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
1 similar comment
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…163319) FIXES pytorch#163286 Pull Request resolved: pytorch#163319 Approved by: https://github.com/eellison
3 participants
Stack from ghstack (oldest at bottom):
FIXES #163286
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben