[CP] Fix cuDNN CP LSE dimension bug#163231
Closed
fegin wants to merge 2 commits intogh/fegin/322/basefrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163231
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d3db0f2 with merge base 7a0f933 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
This was referenced Sep 18, 2025
fegin
added
topic: not user facing
Contributor
|
Test? |
drisspg
reviewed
Sep 18, 2025
| self, block_out: torch.Tensor, block_lse: torch.Tensor, partial: bool | ||
| ) -> None: | ||
| block_lse = block_lse.unsqueeze(dim=-1) | ||
| # The cuDNN backend preserves the last dimension for LSE. |
Contributor
There was a problem hiding this comment.
@eqy what was the reason again for adding the extra dim to LSE?
Collaborator
There was a problem hiding this comment.
I think it's some weirdness around cuDNN expecting 4D in the backward, where before we were manually unsqueeze it to handle that
https://github.com/pytorch/pytorch/pull/155958/files
Contributor
Author
|
@ezyang This PR fixes an existing test. I updated the PR summary. |
eqy
approved these changes
Sep 18, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
We should only unsqueeze if necessary. Fix pytorch#162743 Pull Request resolved: pytorch#163231 Approved by: https://github.com/eqy ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
We should only unsqueeze if necessary. Fix pytorch#162743 Pull Request resolved: pytorch#163231 Approved by: https://github.com/eqy ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
We should only unsqueeze if necessary. Fix pytorch#162743 Pull Request resolved: pytorch#163231 Approved by: https://github.com/eqy ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We should only unsqueeze if necessary.
Fix #162743
cc @H-Huang @awgu @wanchaol @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim @dcci