[aoti] AOTI mingw cross compilation by yushangdi · Pull Request #163188 · pytorch/pytorch

yushangdi · 2025-09-17T20:26:52Z

To run this, you need to install mingw64-gcc-c++ and download windows cuda library toolkit.

See design doc and demo instructions in https://docs.google.com/document/d/1iDaChqA5nNKkBFTzsdkmoomvQlXHbnlb1Z4yEp7xaJA/edit?tab=t.0

If cross_platform_target is windows, we do the following:

do not link to sleef. This can be improved in the future if we need it. Currently I avoid it because that requires extra setup on the linux side
Use mingw64-gcc-c++ to compile
Use WINDOWS_CUDA_HOME instead of CUDA_HOME when linking to cuda

 python test/inductor/test_aot_inductor_windows.py -k so

Other changes:

de-couples compile_standalone config and dynamic link flag
create a new aot_inductor_mode config module, which is used to control configs in aot_inductor.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

pytorch-bot · 2025-09-17T20:26:55Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163188

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit c9d7065 with merge base 232dd65 ():

CANCELLED JOB - The following job was cancelled. Please retry:

Lint / lintrunner-clang / linux-job (gh)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

yushangdi · 2025-09-17T22:04:49Z

torch/_inductor/codegen/cpp_wrapper_gpu.py

                self.prefix.splice(
                    f"""
-                    if ((long({input_name}.data_ptr()) & ({GPU_ALIGN_BYTES} -1)) != 0) {{
+                    if ((reinterpret_cast<std::uintptr_t>({input_name}.data_ptr()) & ({GPU_ALIGN_BYTES} -1)) != 0) {{


has to change this for windows cross-compilation. This should also work for linux.

torch/_inductor/config.py

yushangdi · 2025-09-17T22:45:23Z

torch/csrc/inductor/aoti_runtime/model_base.h

 #pragma once
 #ifdef _WIN32
-#include <Windows.h>
+#include <windows.h>


has to use lower case for cross-compilation. windows is not case-sensitive, but linux is

ezyang · 2025-09-21T02:52:35Z

Neat! Who is using AOTI on Windows? Can you show evidence that this is running on our Windows CI? Thanks!

(Not a full review, deferring to AOTI peeps)

yushangdi · 2025-09-22T16:50:02Z

Neat! Who is using AOTI on Windows? Can you show evidence that this is running on our Windows CI? Thanks!

(Not a full review, deferring to AOTI peeps)

@ezyang This is for Executorch (aka limited unified runtime) to use AOTI as a backend for windows. I haven't added this to windows CI yet, but that's next step!

torch/_inductor/config.py

torch/_inductor/cpp_builder.py

torch/utils/cpp_extension.py

test/inductor/test_aot_inductor_windows.py

albanD · 2025-09-24T20:02:50Z

test/inductor/test_aot_inductor_windows.py

+        return x
+
+
+class TestAOTInductorWindowsCrossCompilation(TestCase):


I am really not sure how to test this cross compilation workflow in CI.

@seemethere for context: we build a binary on linux with mingw and then run it on windows.
any recommendation on how to test that?

The only thing I can think of would be to have a two workflows one after the other, but that might be a lot of setup work?

If we have WSL on the windows CI, we can build this in WSL, and then run the rest on windows. This is how I'm testing it locally as well.

albanD

Sounds good to me!
We can follow up with Eli on the testing.

I will let Bin approve this one though since I might have missed some things here.

desertfire · 2025-09-25T01:02:55Z

torch/_inductor/cpp_builder.py

 _IS_LINUX = sys.platform.startswith("linux")
 _IS_MACOS = sys.platform.startswith("darwin")
 _IS_WINDOWS = sys.platform == "win32"
+AOTI_SHIM_LIB = os.environ.get("AOTI_SHIM_LIB")  # used for AOTI cross-compilation


I feel this naming does not distinguish from config.aot_inductor.aoti_shim_library.

Maybe AOTI_SHIM_LIBRARY_PATH?

Better. Also why don't we have a corresponding config for this one. Ad hoc environment variable makes it hard for users to discover.

make sense. I updated this to a config now.

torch/_inductor/config.py

yushangdi · 2025-09-29T21:14:50Z

@pytorchbot merge

pytorchmergebot · 2025-09-29T21:16:42Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-29T21:16:53Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-clang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

yushangdi · 2025-09-30T23:18:50Z

@pytorchbot merge

pytorchmergebot · 2025-09-30T23:20:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-30T23:20:53Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-clang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

yushangdi · 2025-10-01T02:14:39Z

@pytorchbot merge -i

pytorchmergebot · 2025-10-01T02:16:26Z

Merge started

Your change will be merged while ignoring the following 1 checks: Lint / lintrunner-clang / linux-job

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

To run this, you need to install `mingw64-gcc-c++` and download windows cuda library toolkit. See design doc and demo instructions in https://docs.google.com/document/d/1iDaChqA5nNKkBFTzsdkmoomvQlXHbnlb1Z4yEp7xaJA/edit?tab=t.0 If cross_platform_target is windows, we do the following: - do not link to `sleef`. This can be improved in the future if we need it. Currently I avoid it because that requires extra setup on the linux side - Use `mingw64-gcc-c++` to compile - Use `WINDOWS_CUDA_HOME` instead of `CUDA_HOME` when linking to cuda ``` python test/inductor/test_aot_inductor_windows.py -k so ``` Other changes: - de-couples compile_standalone config and dynamic link flag - create a new aot_inductor_mode config module, which is used to control configs in aot_inductor. Pull Request resolved: pytorch#163188 Approved by: https://github.com/desertfire

pytorch-bot bot added ciflow/inductor module: inductor release notes: inductor (aoti) labels Sep 17, 2025

yushangdi force-pushed the aoti_windows_mingw_2 branch from a5417a9 to b463579 Compare September 17, 2025 21:51

yushangdi commented Sep 17, 2025

View reviewed changes

torch/_inductor/config.py Outdated Show resolved Hide resolved

yushangdi force-pushed the aoti_windows_mingw_2 branch 2 times, most recently from 8b8abf2 to 0436a69 Compare September 17, 2025 22:39

yushangdi commented Sep 17, 2025

View reviewed changes

mingw cross compilation

e5ed60a

yushangdi force-pushed the aoti_windows_mingw_2 branch from 0436a69 to e5ed60a Compare September 17, 2025 22:48

yushangdi marked this pull request as ready for review September 18, 2025 17:49

yushangdi requested review from angelayi, avikchaudhuri, ezyang, fmassa, malfet, tugsbayasgalan, ydwu4 and zhxchen17 as code owners September 18, 2025 17:49

yushangdi changed the title ~~mingw cross compilation v2~~ [aoti] AOTI mingw cross compilation Sep 18, 2025

angelayi requested a review from xuhancn September 22, 2025 01:10

use executorch lib

d66aa72

albanD reviewed Sep 23, 2025

View reviewed changes

mergennachin self-requested a review September 23, 2025 22:55

minor fixes

450803e

albanD reviewed Sep 24, 2025

View reviewed changes

yushangdi requested a review from desertfire September 24, 2025 21:54

desertfire reviewed Sep 25, 2025

View reviewed changes

desertfire self-requested a review September 26, 2025 00:12

statically link stdc libraries

33099a6

yushangdi force-pushed the aoti_windows_mingw_2 branch from 3db0fe5 to 33099a6 Compare September 29, 2025 16:37

desertfire approved these changes Sep 29, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2025

pytorchmergebot added the merging label Sep 29, 2025

pytorchmergebot removed the merging label Sep 29, 2025

yushangdi force-pushed the aoti_windows_mingw_2 branch from a05f4e4 to 5a49abe Compare September 30, 2025 16:21

fix config for compile_standalone tests

c9d7065

yushangdi force-pushed the aoti_windows_mingw_2 branch from 5a49abe to c9d7065 Compare September 30, 2025 18:10

pytorchmergebot added the merging label Sep 30, 2025

pytorchmergebot removed the merging label Sep 30, 2025

pytorchmergebot added the merging label Oct 1, 2025

pytorchmergebot added the Merged label Oct 1, 2025

pytorchmergebot closed this in 28c1d2f Oct 1, 2025

pytorchmergebot removed the merging label Oct 1, 2025

github-actions bot deleted the aoti_windows_mingw_2 branch November 1, 2025 02:20

		return x


		class TestAOTInductorWindowsCrossCompilation(TestCase):

Conversation

yushangdi commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163188

❌ 1 Cancelled Job

Uh oh!

yushangdi Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yushangdi Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

ezyang commented Sep 21, 2025

Uh oh!

yushangdi commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

albanD Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

yushangdi Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

desertfire Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

yushangdi Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

desertfire Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

yushangdi Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yushangdi commented Sep 29, 2025

Uh oh!

pytorchmergebot commented Sep 29, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 29, 2025

Merge failed

Uh oh!

yushangdi commented Sep 30, 2025

Uh oh!

pytorchmergebot commented Sep 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 30, 2025

Merge failed

Uh oh!

yushangdi commented Oct 1, 2025

Uh oh!

pytorchmergebot commented Oct 1, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

yushangdi commented Sep 17, 2025 •

edited

Loading

pytorch-bot bot commented Sep 17, 2025 •

edited

Loading

yushangdi commented Sep 22, 2025 •

edited

Loading

yushangdi Sep 25, 2025 •

edited

Loading