Turn on capture_scalar_outputs when fullgraph=True#163121
Closed
bobrenjc93 wants to merge 7 commits intogh/bobrenjc93/561/basefrom
Closed
Turn on capture_scalar_outputs when fullgraph=True#163121bobrenjc93 wants to merge 7 commits intogh/bobrenjc93/561/basefrom
bobrenjc93 wants to merge 7 commits intogh/bobrenjc93/561/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163121
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d760eeb with merge base 39450e7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bobrenjc93
added
topic: not user facing
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
bobrenjc93
commented
Sep 17, 2025
| return torch.linalg.lstsq(torch.rand(10, 10), torch.rand(10, 10))""", | ||
| ) | ||
|
|
||
| def test_data_dependent_operator(self): |
Contributor
Author
There was a problem hiding this comment.
this test is no longer relevant since we don't expect to ever throw an error anymore. in the case of fullgraph=False we graph break (but don't error, which is what this test suite is for)
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Contributor
|
Can we add a comment closer to the when fullgraph=True documentation |
laithsakka
approved these changes
Sep 18, 2025
Collaborator
|
Starting merge as part of PR stack under #163123 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 18, 2025
Pull Request resolved: #163123 Approved by: https://github.com/laithsakka ghstack dependencies: #163121
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Pull Request resolved: pytorch#163121 Approved by: https://github.com/laithsakka
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…#163123) Pull Request resolved: pytorch#163123 Approved by: https://github.com/laithsakka ghstack dependencies: pytorch#163121
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
Pull Request resolved: pytorch#163121 Approved by: https://github.com/laithsakka
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…#163123) Pull Request resolved: pytorch#163123 Approved by: https://github.com/laithsakka ghstack dependencies: pytorch#163121
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Pull Request resolved: pytorch#163121 Approved by: https://github.com/laithsakka
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…#163123) Pull Request resolved: pytorch#163123 Approved by: https://github.com/laithsakka ghstack dependencies: pytorch#163121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela