Skip to content

[ROCm][CI] update _rocm-test.yml based on _linux-test.yml#163014

Closed
jeffdaily wants to merge 2 commits intomainfrom
rocm-test-yml-update
Closed

[ROCm][CI] update _rocm-test.yml based on _linux-test.yml#163014
jeffdaily wants to merge 2 commits intomainfrom
rocm-test-yml-update

Conversation

@jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Sep 15, 2025 •
edited by pytorch-bot bot
Loading

@jeffdaily jeffdaily requested a review from huydhn September 15, 2025 22:37
@jeffdaily jeffdaily requested a review from a team as a code owner September 15, 2025 22:37
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163014

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 55 Pending

As of commit 1d141f9 with merge base 8590c3a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Sep 15, 2025
huydhn
huydhn reviewed Sep 15, 2025
View reviewed changes
huydhn
huydhn approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to remove VLLM_TEST_HUGGING_FACE_TOKEN before landing as we don't need it here atm

@jeffdaily
Copy link
Collaborator Author

jeffdaily commented Sep 16, 2025

@pytorchbot merge -f "only change to _rocm-test.yml, and relevant rocm flows were passing"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 16, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@jeffdaily @markc-614
[ROCm][CI] update _rocm-test.yml based on _linux-test.yml (pytorch#16…
e804406 
…3014)

Fixes missing huggingface secrets and aligns _rocm-test.yml with other updates from _linux-test.yml that it was initially based on.

Pull Request resolved: pytorch#163014
Approved by: https://github.com/huydhn
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@jeffdaily @mansiag05
[ROCm][CI] update _rocm-test.yml based on _linux-test.yml (pytorch#16…
dcda9d9 
…3014)

Fixes missing huggingface secrets and aligns _rocm-test.yml with other updates from _linux-test.yml that it was initially based on.

Pull Request resolved: pytorch#163014
Approved by: https://github.com/huydhn
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@jeffdaily @cleonard530
[ROCm][CI] update _rocm-test.yml based on _linux-test.yml (pytorch#16…
3216149 
…3014)

Fixes missing huggingface secrets and aligns _rocm-test.yml with other updates from _linux-test.yml that it was initially based on.

Pull Request resolved: pytorch#163014
Approved by: https://github.com/huydhn
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@jeffdaily @dsashidh
[ROCm][CI] update _rocm-test.yml based on _linux-test.yml (pytorch#16…
8bf63b0 
…3014)

Fixes missing huggingface secrets and aligns _rocm-test.yml with other updates from _linux-test.yml that it was initially based on.

Pull Request resolved: pytorch#163014
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the rocm-test-yml-update branch October 17, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/inductor-periodic ciflow/rocm Trigger "default" config CI on ROCm Merged module: dynamo module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffdaily @pytorchmergebot @huydhn @pytorchbot