Skip to content

[DTensor] Add _foreach_pow to sharding propagation list.#162895

Closed
dcci wants to merge 1 commit intopytorch:mainfrom
dcci:propagate-pow
Closed

[DTensor] Add _foreach_pow to sharding propagation list.#162895
dcci wants to merge 1 commit intopytorch:mainfrom
dcci:propagate-pow

Conversation

@dcci
Copy link
Member

@dcci dcci commented Sep 14, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162895

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a30ac2c with merge base 5b9114b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Sep 14, 2025
@dcci
Copy link
Member Author

dcci commented Sep 14, 2025

I believe this is correct -- but please keep me honest, as I'm still learning DTensor :)

  • I wanted to use this as an opportunity to think more broadly about testing -- how do we make sure all the combinations are hit? (i.e. pow/pow_ and also the scalar/tensor variants). Happy to add more stuffs (cc: @ezyang) but I feel like we might want to think a bit on how to cover all the basics

@dcci dcci added the release notes: distributed (dtensor) release notes category label Sep 14, 2025
@dcci dcci mentioned this pull request Sep 14, 2025
Closed
@dcci dcci requested review from bdhirsh and zpcore September 14, 2025 03:31
@dcci
Copy link
Member Author

dcci commented Sep 14, 2025

The failure is unrelated, retriggering CI

@ezyang
Copy link
Contributor

ezyang commented Sep 14, 2025

There should probably be an fail that is now passing

@dcci
Copy link
Member Author

dcci commented Sep 14, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 14, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 14, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 14, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@dcci
Copy link
Member Author

dcci commented Sep 15, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 15, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@dcci @markc-614
[DTensor] Add _foreach_pow to sharding propagation list. (pytorch#162895
c2cf3cf 
)

Fixes pytorch#152696

Pull Request resolved: pytorch#162895
Approved by: https://github.com/ezyang
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@dcci @mansiag05
[DTensor] Add _foreach_pow to sharding propagation list. (pytorch#162895
411067b 
)

Fixes pytorch#152696

Pull Request resolved: pytorch#162895
Approved by: https://github.com/ezyang
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@dcci @cleonard530
[DTensor] Add _foreach_pow to sharding propagation list. (pytorch#162895
1af6009 
)

Fixes pytorch#152696

Pull Request resolved: pytorch#162895
Approved by: https://github.com/ezyang
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@dcci @dsashidh
[DTensor] Add _foreach_pow to sharding propagation list. (pytorch#162895
21359f3 
)

Fixes pytorch#152696

Pull Request resolved: pytorch#162895
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@fduwjj fduwjj Awaiting requested review from fduwjj

@wanchaol wanchaol Awaiting requested review from wanchaol

@XilunWu XilunWu Awaiting requested review from XilunWu

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@zpcore zpcore Awaiting requested review from zpcore

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch._foreach_pow(DTensor, float) and torch._foreach_pow_(DTensor, float) do not work

3 participants

@dcci @ezyang @pytorchmergebot