[MPS] Fix [nan]median output for empty tensors#162846
Closed
malfet wants to merge 2 commits intogh/malfet/518/basefrom
Closed
[MPS] Fix [nan]median output for empty tensors#162846malfet wants to merge 2 commits intogh/malfet/518/basefrom
[nan]median output for empty tensors#162846malfet wants to merge 2 commits intogh/malfet/518/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162846
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d32398e with merge base 38afeb2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
dcci
approved these changes
Sep 12, 2025
Contributor
Author
|
@pytorchbot merge -f "Everything is green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
It should be `NaN` rather than 0 Added respective checks to `test_empty_tensor` Fixes pytorch#162798 Pull Request resolved: pytorch#162846 Approved by: https://github.com/dcci
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
It should be `NaN` rather than 0 Added respective checks to `test_empty_tensor` Fixes pytorch#162798 Pull Request resolved: pytorch#162846 Approved by: https://github.com/dcci
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
It should be `NaN` rather than 0 Added respective checks to `test_empty_tensor` Fixes pytorch#162798 Pull Request resolved: pytorch#162846 Approved by: https://github.com/dcci
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
It should be `NaN` rather than 0 Added respective checks to `test_empty_tensor` Fixes pytorch#162798 Pull Request resolved: pytorch#162846 Approved by: https://github.com/dcci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
[nan]medianoutput for empty tensors #162846It should be
NaNrather than 0Added respective checks to
test_empty_tensorFixes #162798