Skip to content

[MPS] Fix [nan]median output for empty tensors#162846

Closed
malfet wants to merge 2 commits intogh/malfet/518/basefrom
gh/malfet/518/head
Closed

[MPS] Fix [nan]median output for empty tensors#162846
malfet wants to merge 2 commits intogh/malfet/518/basefrom
gh/malfet/518/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 12, 2025

Stack from ghstack (oldest at bottom):

It should be NaN rather than 0

Added respective checks to test_empty_tensor

Fixes #162798

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162846

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d32398e with merge base 38afeb2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Sep 12, 2025
[ghstack-poisoned]
@malfet malfet added the topic: bug fixes topic category label Sep 12, 2025
@malfet malfet requested review from Skylion007 and dcci September 12, 2025 20:34
@malfet
Copy link
Contributor Author

malfet commented Sep 12, 2025

@pytorchbot merge -f "Everything is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
It should be `NaN` rather than 0

Added respective checks to `test_empty_tensor`

Fixes pytorch#162798
Pull Request resolved: pytorch#162846
Approved by: https://github.com/dcci
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
It should be `NaN` rather than 0

Added respective checks to `test_empty_tensor`

Fixes pytorch#162798
Pull Request resolved: pytorch#162846
Approved by: https://github.com/dcci
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
It should be `NaN` rather than 0

Added respective checks to `test_empty_tensor`

Fixes pytorch#162798
Pull Request resolved: pytorch#162846
Approved by: https://github.com/dcci
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
It should be `NaN` rather than 0

Added respective checks to `test_empty_tensor`

Fixes pytorch#162798
Pull Request resolved: pytorch#162846
Approved by: https://github.com/dcci
@github-actions github-actions bot deleted the gh/malfet/518/head branch October 13, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants