Skip to content

compile_kernel large shared memory fix#162647

Closed
msaroufim wants to merge 11 commits intomainfrom
more_ck_Fixes
Closed

compile_kernel large shared memory fix#162647
msaroufim wants to merge 11 commits intomainfrom
more_ck_Fixes

Conversation

@msaroufim
Copy link
Member

@msaroufim msaroufim commented Sep 10, 2025 •
edited
Loading

Alternate solution to #162328

cc @gau-nernst

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162647

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit be8be76 with merge base e254548 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@msaroufim msaroufim marked this pull request as draft September 10, 2025 22:19
@msaroufim msaroufim added the release notes: cuda release notes category label Sep 10, 2025
@msaroufim msaroufim marked this pull request as ready for review September 10, 2025 23:12
gau-nernst
gau-nernst reviewed Sep 11, 2025
View reviewed changes
@gau-nernst gau-nernst mentioned this pull request Sep 11, 2025
Closed
@msaroufim msaroufim requested a review from malfet September 11, 2025 00:29
@msaroufim
Copy link
Member Author

msaroufim commented Sep 11, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 11, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 11, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@msaroufim
Copy link
Member Author

msaroufim commented Sep 11, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 11, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@msaroufim
Copy link
Member Author

msaroufim commented Sep 11, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 11, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@msaroufim @markc-614
compile_kernel large shared memory fix (pytorch#162647)
503ce85 
Alternate solution to pytorch#162328

Pull Request resolved: pytorch#162647
Approved by: https://github.com/eqy
@msaroufim msaroufim mentioned this pull request Sep 17, 2025
Open
20 tasks
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@msaroufim @mansiag05
compile_kernel large shared memory fix (pytorch#162647)
b9281e6 
Alternate solution to pytorch#162328

Pull Request resolved: pytorch#162647
Approved by: https://github.com/eqy
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@msaroufim @cleonard530
compile_kernel large shared memory fix (pytorch#162647)
c79731e 
Alternate solution to pytorch#162328

Pull Request resolved: pytorch#162647
Approved by: https://github.com/eqy
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@msaroufim @dsashidh
compile_kernel large shared memory fix (pytorch#162647)
5dd22c2 
Alternate solution to pytorch#162328

Pull Request resolved: pytorch#162647
Approved by: https://github.com/eqy
@github-actions github-actions bot deleted the more_ck_Fixes branch October 12, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eqy eqy eqy approved these changes

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@malfet malfet Awaiting requested review from malfet

+1 more reviewer

@gau-nernst gau-nernst gau-nernst left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: cuda release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msaroufim @pytorchmergebot @eqy @gau-nernst