[xpu][feature] enable Sycl CPP extension on Windows by tbohutyn · Pull Request #162579 · pytorch/pytorch

tbohutyn · 2025-09-10T11:08:29Z

PR for enabling #153265 on Windows

pytorch-bot · 2025-09-10T11:08:33Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162579

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

dvrogozh · 2025-09-10T14:18:54Z

@pytorchbot label "release notes: xpu"

dvrogozh · 2025-09-10T14:22:23Z

@tbohutyn, can you, please, make 2 book keeping changes:

Rename the PR to state affinity with XPU and Sycl cpp extension. For example, "xpu: enable Sycl CPP extension on Windows"
Describe current status in the PR description. From internal discussion it seems that /sdl option passed to DPC++ compiler breaks compilation. This needs to be stated as a reason for PR to be a draft.

torch/utils/cpp_extension.py

test/test_cpp_extensions_jit.py

torch/utils/cpp_extension.py

EikanWang · 2025-09-11T00:08:43Z

torch/utils/cpp_extension.py

-    ]
+    if IS_WINDOWS:
+        host_cflags = [
+            "-fsycl",


I'm curious why Windows build requires -fsycl, while Linux does not.

EikanWang · 2025-09-11T02:40:20Z

torch/utils/cpp_extension.py



-def _prepare_ldflags(extra_ldflags, with_cuda, verbose, is_standalone):
+def _prepare_ldflags(extra_ldflags, with_cuda, with_sycl, verbose, is_standalone):


Could you help generalize it a little bit by handling with_cuda and with_sycl with different functions accordingly?

test/test_cpp_extensions_jit.py

torch/utils/cpp_extension.py

dvrogozh · 2025-09-17T19:11:27Z

torch/utils/cpp_extension.py

+
+        external_include = _join_sycl_home("include").replace("\\", "\\\\")
+        wrapped_host_cflags = [
+            f"-fsycl-host-compiler={host_cxx}",


The /std:c++17 which you add on the next line is actually handled by append_std17_if_no_std_present(host_cflags) which you also call. Can you drop explicit /std:c++17 from the line below?

torch/utils/cpp_extension.py

test/test_cpp_extensions_jit.py

dvrogozh

LGTM

test/test_cpp_extensions_jit.py

guangyey · 2025-10-24T03:42:57Z

torch/utils/cpp_extension.py

                extra_ldflags.append(f'-L{_join_rocm_home("lib")}')
                extra_ldflags.append('-lamdhip64')
+    if with_sycl:
+        if IS_WINDOWS:


@dvrogozh I know this is not directly related to this PR, but I’m curious — why isn’t there a Linux branch here?

I looked into this. These libraries are needed for both Windows and Linux, otherwise there will be unresolved symbols. The reason why it works on Linux without adding these libraries on the command line is 1) lazy linkage on the build stage, 2) global symbol resolution at runtime (i.e. required libraries are already loaded by import torch by the time extension is being loaded and symbols got resolved).

I think it makes sense to align the code between xpu and cuda/hip and add these libs on Linux as well. @tbohutyn, I have submitted a PR against your fork: tbohutyn#1. It adds libs on Linux and adds a test to formally test this out. Please, take a look on PR and merge to your fork if you are ok with it. Once done your pytorch PR will be automatically updated.

Thanks @dvrogozh

@tbohutyn, can you, please, take a look at tbohutyn#1 PR and let me know if you plan to merge it in or you would like me to follow up on 162579 once it's merged?

I think it would be better to handle this as a follow-up since it targets Linux, while this PR focuses on Windows.

I am fine with that. I'll post the Linux PR as soon as this one will get merged as they partially overlap and there will be conflicts to resolve. @guangyey, please, help to merge Windows PR.

Filed #169322.

pytorch-bot · 2025-11-21T03:16:56Z

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

albanD · 2025-11-25T14:35:51Z

test/test_cpp_extensions_jit.py

-            shutil.rmtree(temp_dir)
+            if IS_WINDOWS:
+                # rmtree returns permission error: [WinError 5] Access is denied
+                # on Windows, this is a workaround


Why not set ignore_error=True in rmtree?

@tbohutyn : can you, please, check if that's something which can be quick addressed? If not, please, post a note here and let's do that as a follow up.

astachowiczhabana · 2025-11-28T14:29:10Z

Hi @EikanWang
I'm taking over this PR after @tbohutyn (he's no longer available). The failing test (xpu / linux-noble-xpu-n-py3.10 / test ) is unrelated to the changes in this PR. It’s caused by a timeout issue that has been observed in other PRs as well HUD.

EikanWang · 2025-11-29T13:17:21Z

@pytorchbot merge

pytorchmergebot · 2025-11-29T13:19:14Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-11-29T13:19:18Z

Merge failed

Reason: 1 jobs have failed, first few of them are: xpu / linux-noble-xpu-n-py3.10 / test (default, 7, 12, linux.idc.xpu)

Details for Dev Infra team

Raised by workflow job

EikanWang · 2025-11-30T02:45:15Z

@pytorchbot merge -i

pytorchmergebot · 2025-11-30T02:47:05Z

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-11-30T08:45:39Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

EikanWang · 2025-12-01T02:42:49Z

@pytorchbot merge -i

pytorchmergebot · 2025-12-01T02:44:34Z

Merge started

Your change will be merged while ignoring the following 1 checks: xpu / linux-noble-xpu-n-py3.10 / test (default, 7, 12, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

A follow up on the noticed Linux specific issue for sycl cpp extension. We need to link with more libraries we are linking so far. Issue got unnoticed as these libraries were already loaded during torch import. This commit adds missing libs formally to the linker cmdline and adds test for such a case. See pytorch#162579 (comment) Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>

A follow up on the noticed Linux specific issue for sycl cpp extension. We need to link with more libraries we are linking so far. Issue got unnoticed as these libraries were already loaded during torch import. The dd18a75 commit has added missing libs formally to the linker cmdline. Current commit further adds test for such a case. See pytorch#162579 (comment) Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>

PR for enabling #153265 on Windows Pull Request resolved: #162579 Approved by: https://github.com/dvrogozh, https://github.com/EikanWang, https://github.com/guangyey, https://github.com/albanD

pytorchbot added the open source label Sep 10, 2025

pytorch-bot bot added the release notes: xpu release notes category label Sep 10, 2025

dvrogozh reviewed Sep 10, 2025

View reviewed changes

torch/utils/cpp_extension.py Outdated Show resolved Hide resolved

guangyey added this to PyTorch Intel Sep 11, 2025

guangyey requested review from EikanWang and gujinghui September 11, 2025 02:00

guangyey reviewed Sep 11, 2025

View reviewed changes

torch/utils/cpp_extension.py Outdated Show resolved Hide resolved

guangyey reviewed Sep 11, 2025

View reviewed changes

torch/utils/cpp_extension.py Outdated Show resolved Hide resolved

EikanWang reviewed Sep 11, 2025

View reviewed changes

tbohutyn changed the title ~~cpp extension on windows~~ xpu: enable Sycl CPP extension on Windows Sep 12, 2025

tbohutyn force-pushed the windows_cpp_extension branch from feb3469 to 335362b Compare September 17, 2025 15:52

dvrogozh reviewed Sep 17, 2025

View reviewed changes

dvrogozh mentioned this pull request Sep 19, 2025

nd_item::barrier has been deprecated intel/torch-xpu-ops#2086

Open

tbohutyn mentioned this pull request Sep 26, 2025

CPP extension, extend from Linux to windows intel/torch-xpu-ops#1852

Open

tbohutyn force-pushed the windows_cpp_extension branch from 335362b to 2226143 Compare September 29, 2025 13:57

tbohutyn marked this pull request as ready for review September 29, 2025 15:13

tbohutyn requested review from ezyang, fmassa and malfet as code owners September 29, 2025 15:13

tbohutyn commented Sep 29, 2025

View reviewed changes

test/test_cpp_extensions_jit.py Show resolved Hide resolved

jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 29, 2025

tbohutyn force-pushed the windows_cpp_extension branch from 0e32f7c to b05ee61 Compare October 15, 2025 15:52

dvrogozh approved these changes Oct 15, 2025

View reviewed changes

EikanWang approved these changes Oct 15, 2025

View reviewed changes

etaf reviewed Oct 16, 2025

View reviewed changes

test/test_cpp_extensions_jit.py Outdated Show resolved Hide resolved

tbohutyn force-pushed the windows_cpp_extension branch from b05ee61 to 4f0320f Compare October 22, 2025 11:58

guangyey reviewed Oct 24, 2025

View reviewed changes

EikanWang added ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end labels Nov 21, 2025

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2025

EikanWang added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2025

albanD reviewed Nov 25, 2025

View reviewed changes

albanD approved these changes Nov 25, 2025

View reviewed changes

pytorchmergebot added the merging label Nov 29, 2025

pytorchmergebot removed the merging label Nov 29, 2025

pytorchmergebot added the merging label Nov 30, 2025

pytorchmergebot added the Merged label Dec 1, 2025

pytorchmergebot closed this in 94ca8d5 Dec 1, 2025

github-project-automation bot moved this from Review Required to Done in PyTorch Intel Dec 1, 2025

pytorchmergebot removed the merging label Dec 1, 2025

dvrogozh mentioned this pull request Dec 1, 2025

xpu: add a test to verify all torch xpu libraries are linked on Linux #169322

Open



		def _prepare_ldflags(extra_ldflags, with_cuda, verbose, is_standalone):
		def _prepare_ldflags(extra_ldflags, with_cuda, with_sycl, verbose, is_standalone):

Conversation

tbohutyn commented Sep 10, 2025

Uh oh!

pytorch-bot bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162579

Uh oh!

dvrogozh commented Sep 10, 2025

Uh oh!

dvrogozh commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dvrogozh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pytorch-bot bot commented Nov 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

astachowiczhabana commented Nov 28, 2025

Uh oh!

EikanWang commented Nov 29, 2025

Uh oh!

pytorchmergebot commented Nov 29, 2025

Merge started

Uh oh!

pytorchmergebot commented Nov 29, 2025

Merge failed

Uh oh!

EikanWang commented Nov 30, 2025

Uh oh!

pytorchmergebot commented Nov 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Nov 30, 2025

Uh oh!

EikanWang commented Dec 1, 2025

Uh oh!

pytorchmergebot commented Dec 1, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

pytorch-bot bot commented Sep 10, 2025 •

edited

Loading