[Cutlass] Add exp and sigmoid activations#162536
[Cutlass] Add exp and sigmoid activations#162536mlazos wants to merge 1 commit intogh/mlazos/19/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162536
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 28f268d with merge base 49c446c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for exp and sigmoid activation functions to the CUTLASS backend by implementing the corresponding operations in the EVT (Epilogue Visitor Tree) system. The changes enable these mathematical functions to be used in CUTLASS-accelerated operations.
- Replaces NotImplementedError for sigmoid with actual implementation
- Adds new exp activation function implementation
- Updates test coverage to include both new activations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| torch/_inductor/codegen/cuda/cutlass_python_evt.py | Implements sigmoid and exp operations using the _prefix_un_op helper |
| test/inductor/test_cutlass_backend.py | Adds exp and sigmoid to the list of unary operations under test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
4 participants
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben