[Cutlass] Add tanh activation and test case for activations#162535
Closed
mlazos wants to merge 1 commit intogh/mlazos/18/basefrom
Closed
[Cutlass] Add tanh activation and test case for activations#162535mlazos wants to merge 1 commit intogh/mlazos/18/basefrom
mlazos wants to merge 1 commit intogh/mlazos/18/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162535
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 707a674 with merge base 49c446c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the tanh activation function to the CUTLASS Python event handler and includes a new test case for activation functions.
- Replaces the NotImplementedError for
tanhwith proper implementation - Adds
torch.tanhto the list of supported unary operations for testing - Introduces a dedicated test case for activation functions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| torch/_inductor/codegen/cuda/cutlass_python_evt.py | Implements tanh activation by returning the proper function call |
| test/inductor/test_cutlass_backend.py | Adds tanh to test operations and creates new activation test case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
henrylhtsang
approved these changes
Sep 10, 2025
Collaborator
|
Starting merge as part of PR stack under #162536 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 10, 2025
Pull Request resolved: #162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: #162535
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…162535) Pull Request resolved: pytorch#162535 Approved by: https://github.com/henrylhtsang
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…162535) Pull Request resolved: pytorch#162535 Approved by: https://github.com/henrylhtsang
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…162535) Pull Request resolved: pytorch#162535 Approved by: https://github.com/henrylhtsang
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…162535) Pull Request resolved: pytorch#162535 Approved by: https://github.com/henrylhtsang
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Pull Request resolved: pytorch#162536 Approved by: https://github.com/henrylhtsang, https://github.com/eellison ghstack dependencies: pytorch#162535
Khanaksahu
pushed a commit
to Khanaksahu/pytorch-fork
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: 4dc9301 Pull Request resolved: pytorch/pytorch#162535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben