Skip to content

[triton] enable int64 indexing in convolution and mm template#162506

Closed
yuguo68 wants to merge 1 commit intopytorch:mainfrom
yuguo68:export-D81995664
Closed

[triton] enable int64 indexing in convolution and mm template#162506
yuguo68 wants to merge 1 commit intopytorch:mainfrom
yuguo68:export-D81995664

Conversation

@yuguo68
Copy link
Contributor

@yuguo68 yuguo68 commented Sep 9, 2025

Summary: hitting illegal memory access issue when compiling conv and addmm kernels with the change in #157767

Differential Revision: D81995664

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Summary: hitting illegal memory access issue when compiling conv and addmm kernels with the change in pytorch#157767

Differential Revision: D81995664
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162506

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit ad623ac with merge base 5eb35d2 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81995664

Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuguo68 for this fix! It resolved the memory access fault issue on AMD MI300x for an internal use case with memory stress.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2025
@yuguo68
Copy link
Contributor Author

yuguo68 commented Sep 10, 2025

@pytorchmergebot merge -f "test failure not related and merged on fbcode"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…h#162506)

Summary: hitting illegal memory access issue when compiling conv and addmm kernels with the change in pytorch#157767

Differential Revision: D81995664

Pull Request resolved: pytorch#162506
Approved by: https://github.com/iseeyuan
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
…h#162506)

Summary: hitting illegal memory access issue when compiling conv and addmm kernels with the change in pytorch#157767

Differential Revision: D81995664

Pull Request resolved: pytorch#162506
Approved by: https://github.com/iseeyuan
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
…h#162506)

Summary: hitting illegal memory access issue when compiling conv and addmm kernels with the change in pytorch#157767

Differential Revision: D81995664

Pull Request resolved: pytorch#162506
Approved by: https://github.com/iseeyuan
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
…h#162506)

Summary: hitting illegal memory access issue when compiling conv and addmm kernels with the change in pytorch#157767

Differential Revision: D81995664

Pull Request resolved: pytorch#162506
Approved by: https://github.com/iseeyuan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants