Skip to content

[dynamo] fix resume_execution.py KeyError in Python 3.11+ #162318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[dynamo] fix resume_execution.py KeyError in Python 3.11+ #162318

wants to merge 2 commits into from

Conversation

@williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Sep 6, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162318

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e230fbc with merge base ef3be67 (image):

NEW FAILURE - The following job has failed:

  • trunk / macos-py3-arm64 / build (gh)
    /Library/Developer/CommandLineTools/usr/lib/clang/15.0.0/include/ammintrin.h:14:2: error: "This header is only meant to be used on x86 and x64 architecture"

This comment was automatically generated by Dr. CI and updates every 15 minutes.

williamwen42 added a commit that referenced this pull request Sep 6, 2025
@williamwen42
[dynamo] fix resume_execution.py KeyError in Python 3.11+
33c3a4f 
ghstack-source-id: bcdab8c
Pull Request resolved: #162318
@williamwen42 williamwen42 added topic: bug fixes topic category release notes: dynamo module: python version Issues related to specific Python versions labels Sep 6, 2025
Lucaskabela
Lucaskabela approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@Lucaskabela Lucaskabela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just need an assertion that value is not None to make mypy happy - otherwise LGTM. Thanks for updating the comment for the variable as well :)

@williamwen42
Update on "[dynamo] fix resume_execution.py KeyError in Python 3.11+"
e230fbc 
Fixes #162313

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela mlazos

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Sep 8, 2025
@williamwen42
[dynamo] fix resume_execution.py KeyError in Python 3.11+
6f7fe00 
ghstack-source-id: 21e2290
Pull Request resolved: #162318
@williamwen42
Copy link
Member Author

williamwen42 commented Sep 8, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 8, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@williamwen42
Copy link
Member Author

williamwen42 commented Sep 8, 2025

@williamwen42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@williamwen42
Copy link
Member Author

williamwen42 commented Sep 8, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@williamwen42
Copy link
Member Author

williamwen42 commented Sep 12, 2025

@pytorchbot cherry-pick --onto release/2.9 --fixes "#162313 - potential crash in Python 3.11+" -c critical

@pytorchbot
Copy link
Collaborator

pytorchbot commented Sep 12, 2025

Cherry picking #162318

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 26a1b9cce29f2edfbed661a229ead67fed613914 returned non-zero exit code 1

The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch cherry-pick-162318-by-pytorch_bot_bot_
You are currently cherry-picking commit 26a1b9cce29.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean
Details for Dev Infra team Raised by workflow job

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@williamwen42 @markc-614
[dynamo] fix resume_execution.py KeyError in Python 3.11+ (pytorch#16…
a11ccec 
…2318)

Fixes pytorch#162313

Differential Revision: [D81938289](https://our.internmc.facebook.com/intern/diff/D81938289)
Pull Request resolved: pytorch#162318
Approved by: https://github.com/Lucaskabela, https://github.com/mlazos, https://github.com/anijain2305
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@williamwen42 @mansiag05
[dynamo] fix resume_execution.py KeyError in Python 3.11+ (pytorch#16…
4f2dc79 
…2318)

Fixes pytorch#162313

Differential Revision: [D81938289](https://our.internmc.facebook.com/intern/diff/D81938289)
Pull Request resolved: pytorch#162318
Approved by: https://github.com/Lucaskabela, https://github.com/mlazos, https://github.com/anijain2305
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@williamwen42 @cleonard530
[dynamo] fix resume_execution.py KeyError in Python 3.11+ (pytorch#16…
50c5d68 
…2318)

Fixes pytorch#162313

Differential Revision: [D81938289](https://our.internmc.facebook.com/intern/diff/D81938289)
Pull Request resolved: pytorch#162318
Approved by: https://github.com/Lucaskabela, https://github.com/mlazos, https://github.com/anijain2305
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@williamwen42 @dsashidh
[dynamo] fix resume_execution.py KeyError in Python 3.11+ (pytorch#16…
fa47d51 
…2318)

Fixes pytorch#162313

Differential Revision: [D81938289](https://our.internmc.facebook.com/intern/diff/D81938289)
Pull Request resolved: pytorch#162318
Approved by: https://github.com/Lucaskabela, https://github.com/mlazos, https://github.com/anijain2305
@github-actions github-actions bot deleted the gh/williamwen42/289/head branch October 13, 2025 02:15
@williamwen42 williamwen42 mentioned this pull request Oct 21, 2025
Closed
williamwen42 added a commit that referenced this pull request Oct 27, 2025
@williamwen42
Update on "[dynamo] fix keyerror in resume_execution (again)"
22dbe1f 
The error I attempted to fix in #162318 was still appearing internally.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Oct 27, 2025
@williamwen42
Update on "[dynamo] fix keyerror in resume_execution (again)"
afa8775 
Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰 

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Oct 28, 2025
@williamwen42 @pytorchmergebot
[dynamo] fix keyerror in resume_execution (again) (#166040)
32fe4f6 
Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰

Pull Request resolved: #166040
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166036
Lucaskabela pushed a commit that referenced this pull request Nov 4, 2025
@williamwen42 @Lucaskabela
[dynamo] fix keyerror in resume_execution (again) (#166040)
b166e70 
Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰

Pull Request resolved: #166040
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166036

(cherry picked from commit 32fe4f6)
Lucaskabela pushed a commit that referenced this pull request Nov 4, 2025
@williamwen42 @Lucaskabela
[dynamo] fix keyerror in resume_execution (again) (#166040)
66250f2 
Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰

Pull Request resolved: #166040
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166036

(cherry picked from commit 32fe4f6)
Lucaskabela pushed a commit that referenced this pull request Nov 4, 2025
@williamwen42 @Lucaskabela
[dynamo] fix keyerror in resume_execution (again) (#166040)
e328b4c 
Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰

Pull Request resolved: #166040
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166036

(cherry picked from commit 32fe4f6)
Lucaskabela pushed a commit that referenced this pull request Nov 4, 2025
@williamwen42 @Lucaskabela
[dynamo] fix keyerror in resume_execution (again) (#166040)
89b01de 
Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰

Pull Request resolved: #166040
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166036

(cherry picked from commit 32fe4f6)
Lucaskabela pushed a commit that referenced this pull request Nov 4, 2025
@williamwen42 @Lucaskabela
[dynamo] fix keyerror in resume_execution (again) (#166040)
61e1943 
Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰

Pull Request resolved: #166040
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166036

(cherry picked from commit 32fe4f6)
atalman pushed a commit that referenced this pull request Nov 5, 2025
@Lucaskabela @williamwen42
[dynamo] fix keyerror in resume_execution, fix store attr (#166924)
13f1b55 
* [dynamo] fix store attr graph break in with block (#166036)

Fixes #166033

Differential Revision: [D85198055](https://our.internmc.facebook.com/intern/diff/D85198055)
Pull Request resolved: #166036
Approved by: https://github.com/Lucaskabela

(cherry picked from commit ebb2b2e)

* [dynamo] fix keyerror in resume_execution (again) (#166040)

Fixes #166176

The error I attempted to fix in #162318 was still appearing internally.

Surprised that this wasn't caught anywhere 😰

Pull Request resolved: #166040
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166036

(cherry picked from commit 32fe4f6)

* fix self.current_instruction -> cur_tx.current_instruction

---------

Co-authored-by: William Wen <williamwen@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlazos mlazos mlazos approved these changes

@anijain2305 anijain2305 anijain2305 approved these changes

@Lucaskabela Lucaskabela Lucaskabela approved these changes

@StrongerXi StrongerXi Awaiting requested review from StrongerXi

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: python version Issues related to specific Python versions release notes: dynamo topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@williamwen42 @pytorchmergebot @pytorchbot @mlazos @anijain2305 @Lucaskabela