Skip to content

[MPS] enable cat op for sparse #162007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] enable cat op for sparse #162007

wants to merge 1 commit into from
+2 −2

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20 Isalia20 commented Sep 2, 2025 •
edited by pytorch-bot bot
Loading

Enable cat op for sparse on MPS

cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162007

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aec1685 with merge base dcf3853 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Isalia20 Isalia20 added module: mps Related to Apple Metal Performance Shaders framework release notes: mps Release notes category ciflow/trunk Trigger trunk jobs on your pull request labels Sep 2, 2025
@Isalia20 Isalia20 requested a review from malfet September 2, 2025 20:51
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@malfet malfet added the topic: improvements topic category label Sep 2, 2025
malfet
malfet previously approved these changes Sep 2, 2025
View reviewed changes
@Isalia20
Copy link
Collaborator Author

Isalia20 commented Sep 3, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 3, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt
Copy link
Contributor

jeanschmidt commented Sep 4, 2025

@pytorchbot revert -m "Breaks internal builds see D81588372, @malfet may you help the author?" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 4, 2025
@pytorchmergebot
Revert "[MPS] enable cat op for sparse (#162007)"
9e5247f 
This reverts commit 2c03f0a.

Reverted #162007 on behalf of https://github.com/jeanschmidt due to Breaks internal builds see [D81588372](https://www.internalfb.com/diff/D81588372), @malfet may you help the author? ([comment](#162007 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2025

@Isalia20 your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 4, 2025
@pytorch-bot pytorch-bot bot dismissed malfet’s stale review September 4, 2025 19:49

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 11, 2025
malfet
malfet approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert were bogus

@malfet
Copy link
Contributor

malfet commented Sep 12, 2025

@pytorchbot revert -m "Breaks internal builds see D81588372, @malfet may you help the author?" -c ghfirst

By looking at the log, it feels like revert was due to a false positive failure

@malfet
Copy link
Contributor

malfet commented Sep 12, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 12, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@Isalia20 @markc-614
[MPS] enable cat op for sparse (pytorch#162007)
33eef1b 
Enable cat op for sparse on MPS

Pull Request resolved: pytorch#162007
Approved by: https://github.com/malfet
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "[MPS] enable cat op for sparse (pytorch#162007)"
83a06c2 
This reverts commit 2c03f0a.

Reverted pytorch#162007 on behalf of https://github.com/jeanschmidt due to Breaks internal builds see [D81588372](https://www.internalfb.com/diff/D81588372), @malfet may you help the author? ([comment](pytorch#162007 (comment)))
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@Isalia20 @markc-614
[MPS] enable cat op for sparse (pytorch#162007)
705ca61 
Enable cat op for sparse on MPS

Pull Request resolved: pytorch#162007
Approved by: https://github.com/malfet
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@Isalia20 @mansiag05
[MPS] enable cat op for sparse (pytorch#162007)
a21783e 
Enable cat op for sparse on MPS

Pull Request resolved: pytorch#162007
Approved by: https://github.com/malfet
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @mansiag05
Revert "[MPS] enable cat op for sparse (pytorch#162007)"
7c8781e 
This reverts commit 2c03f0a.

Reverted pytorch#162007 on behalf of https://github.com/jeanschmidt due to Breaks internal builds see [D81588372](https://www.internalfb.com/diff/D81588372), @malfet may you help the author? ([comment](pytorch#162007 (comment)))
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@Isalia20 @mansiag05
[MPS] enable cat op for sparse (pytorch#162007)
0bc3673 
Enable cat op for sparse on MPS

Pull Request resolved: pytorch#162007
Approved by: https://github.com/malfet
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @cleonard530
Revert "[MPS] enable cat op for sparse (pytorch#162007)"
93e49e0 
This reverts commit 2c03f0a.

Reverted pytorch#162007 on behalf of https://github.com/jeanschmidt due to Breaks internal builds see [D81588372](https://www.internalfb.com/diff/D81588372), @malfet may you help the author? ([comment](pytorch#162007 (comment)))
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@Isalia20 @cleonard530
[MPS] enable cat op for sparse (pytorch#162007)
1099524 
Enable cat op for sparse on MPS

Pull Request resolved: pytorch#162007
Approved by: https://github.com/malfet
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@Isalia20 @dsashidh
[MPS] enable cat op for sparse (pytorch#162007)
2b5c20a 
Enable cat op for sparse on MPS

Pull Request resolved: pytorch#162007
Approved by: https://github.com/malfet
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@pytorchmergebot @dsashidh
Revert "[MPS] enable cat op for sparse (pytorch#162007)"
e6cc068 
This reverts commit 2c03f0a.

Reverted pytorch#162007 on behalf of https://github.com/jeanschmidt due to Breaks internal builds see [D81588372](https://www.internalfb.com/diff/D81588372), @malfet may you help the author? ([comment](pytorch#162007 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@Isalia20 @dsashidh
[MPS] enable cat op for sparse (pytorch#162007)
0b5ddd3 
Enable cat op for sparse on MPS

Pull Request resolved: pytorch#162007
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: mps Related to Apple Metal Performance Shaders framework open source release notes: mps Release notes category Reverted topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Isalia20 @pytorchmergebot @jeanschmidt @malfet @soulitzer @pytorchbot