xpu: fix cpp_extension compatibility with oneapi dpc++ 2025.2 compiler #161012
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161012
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 36d775a with merge base 1de4540 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: xpu" |
|
@pytorchbot label "module: xpu" |
There was a problem hiding this comment.
It is a non-backward-compatible change. Have we reported an issue to the SYCL compiler community?
There was a problem hiding this comment.
I reported the original issue with handling of quoted arguments in intel/llvm#15016 a year ago. They did not update it after that, but it seems that dpc++2025.2 has changed the behavior. I will post a note in this issue.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Intel oneapi DPC++ compiler has changed (fixed) parsing of `-fsycl-host-compiler-options` option in the respect of treating arguments with escaped quotes. This commit adds an if branches depending on compiler versions. Fixes: intel/torch-xpu-ops#1938 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
|
Successfully rebased |
|
@pytorchbot merge |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: xpu / linux-jammy-xpu-2025.1-py3.9 / test (default, 1, 6, linux.idc.xpu) Details for Dev Infra teamRaised by workflow job |
etaf
added
the
keep-going
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch#161012) Intel oneapi DPC++ compiler has changed (fixed) parsing of `-fsycl-host-compiler-options` option in the respect of treating arguments with escaped quotes. This commit adds an if branches depending on compiler versions. Fixes: intel/torch-xpu-ops#1938 CC: @chuanqi129 @EikanWang @guangyey Pull Request resolved: pytorch#161012 Approved by: https://github.com/guangyey, https://github.com/EikanWang, https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
8 participants
Intel oneapi DPC++ compiler has changed (fixed) parsing of
-fsycl-host-compiler-optionsoption in the respect of treating arguments with escaped quotes. This commit adds an if branches depending on compiler versions.Fixes: intel/torch-xpu-ops#1938
CC: @chuanqi129 @EikanWang @guangyey
cc @gujinghui @EikanWang @fengyuan14 @guangyey