Correctly set max_numwarps in coordinate_descent_tuner by jataylo · Pull Request #159146 · pytorch/pytorch

jataylo · 2025-07-25T09:59:59Z

Current max_numwarps is incorrect on ROCm as warp_size is not taken into account. This PR resolves this and handles in a none hardcoded way using device props when available.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

pytorch-bot · 2025-07-25T10:00:04Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159146

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9182ff2 with merge base cf6d089 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ing (#2416) pytorch#159146

…ing (#2416) pytorch#159146 (cherry picked from commit be95f40)

Relands #2416 with caching fix Upstream equivalent pytorch#159146 --------- Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>

Relands #2416 with caching fix Upstream equivalent pytorch#159146 --------- Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> (cherry picked from commit f0aebdc)

…#2421) Relands ROCm#2416 with caching fix Upstream equivalent pytorch#159146 --------- Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> (cherry picked from commit f0aebdc)

iupaikov-amd · 2025-08-20T09:23:10Z

Hello @shunting314 @davidberard98 @jeffdaily !

We would like to have this prior to release/2.9 cut. The main issue is that linter is wary of lru_cache usage because of memory leaks. We've seen it used in other places, is there no way to merge this with lru_cache? Maybe you know other methods of making it more convenient since decorated func will be called a lot.

Regards, Iurii.

Relands #2416 with caching fix Upstream equivalent pytorch#159146 --------- Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> (cherry picked from commit f0aebdc)

davidberard98 · 2025-08-22T06:05:55Z

@iupaikov-amd can you separate the function from the class (I.e make it a function instead of a method) and apply lru cache on that function instead?

iupaikov-amd · 2025-08-29T12:58:44Z

Don't have write access to Jack's fork unfortunately, he'll come back next week and apply what we discussed.

@jataylo PR for your fork: jataylo#1

jataylo · 2025-09-03T09:31:24Z

@pytorchbot rebase

pytorchmergebot · 2025-09-03T09:32:58Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-09-03T09:33:01Z

Successfully rebased warps onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout warps && git pull --rebase)

jataylo · 2025-09-09T10:40:06Z

@pytorchbot rebase

pytorchmergebot · 2025-09-09T10:41:38Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-09-09T10:41:42Z

Successfully rebased warps onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout warps && git pull --rebase)

jataylo · 2025-11-24T23:58:21Z

Cleaned this up, opening for review.

torch/_inductor/runtime/coordinate_descent_tuner.py

jataylo · 2025-12-01T10:23:11Z

@pytorchbot rebase

pytorchmergebot · 2025-12-01T10:24:54Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-12-01T10:24:56Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch push -f https://github.com/jataylo/pytorch.git pull/159146/head:warps returned non-zero exit code 128

remote: The 'AMD' enterprise forbids access via a personal access tokens (classic) if the token's lifetime is greater than 366 days. Please adjust your token's lifetime at the following URL: https://github.com/settings/tokens/779664343
fatal: unable to access 'https://github.com/jataylo/pytorch.git/': The requested URL returned error: 403

Raised by https://github.com/pytorch/pytorch/actions/runs/19819289174

jataylo · 2025-12-03T12:10:48Z

@pytorchbot merge

pytorchmergebot · 2025-12-03T12:12:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Current max_numwarps is incorrect on ROCm as warp_size is not taken into account. This PR resolves this and handles in a none hardcoded way using device props when available. Pull Request resolved: #159146 Approved by: https://github.com/jansel, https://github.com/shunting314

pytorch-bot bot added ciflow/inductor module: inductor labels Jul 25, 2025

jataylo added ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jul 25, 2025

pytorchbot added the open source label Jul 25, 2025

jataylo mentioned this pull request Jul 25, 2025

[release/2.7] [SWDEV-543214] Set max_numwarps based on warp_size instead of hardcoding ROCm/pytorch#2416

Merged

jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull request Jul 25, 2025

[SWDEV-543214] Set max_numwarps based on warp_size instead of hardcod…

be95f40

…ing (#2416) pytorch#159146

jataylo mentioned this pull request Jul 28, 2025

[release/2.7] [SWDEV-543214] Reland #2416 Fix warps runtime ROCm/pytorch#2421

Merged

pragupta pushed a commit to ROCm/pytorch that referenced this pull request Jul 30, 2025

[SWDEV-543214] Set max_numwarps based on warp_size instead of hardcod…

c1ded83

…ing (#2416) pytorch#159146 (cherry picked from commit be95f40)

iupaikov-amd requested review from davidberard98, jeffdaily and shunting314 August 20, 2025 09:23

pytorchmergebot force-pushed the warps branch from 3c04d8d to 8758e6b Compare September 3, 2025 09:33

pytorchmergebot force-pushed the warps branch from e676a49 to 368950e Compare September 9, 2025 10:41

Linting

fb247c5

jataylo requested review from eellison and jansel and removed request for davidberard98 November 24, 2025 23:57

jataylo marked this pull request as ready for review November 24, 2025 23:58

jataylo requested review from Aidyn-A, eqy and syed-ahmed as code owners November 24, 2025 23:58

jansel approved these changes Nov 25, 2025

View reviewed changes

shunting314 reviewed Nov 25, 2025

View reviewed changes

torch/_inductor/runtime/coordinate_descent_tuner.py Outdated Show resolved Hide resolved

Apply PR comments to use inductor_meta

f1f0dc7

jataylo requested a review from shunting314 December 2, 2025 11:08

jataylo added 3 commits December 2, 2025 11:32

Linting

e084cf1

Linting

c721f4f

Final lint

9182ff2

shunting314 approved these changes Dec 2, 2025

View reviewed changes

jataylo added the topic: not user facing topic category label Dec 3, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 3, 2025

pytorchmergebot added the merging label Dec 3, 2025

pytorchmergebot added the Merged label Dec 3, 2025

pytorchmergebot closed this in 597930f Dec 3, 2025

pytorchmergebot removed the merging label Dec 3, 2025

Conversation

jataylo commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159146

✅ No Failures

Uh oh!

iupaikov-amd commented Aug 20, 2025

Uh oh!

davidberard98 commented Aug 22, 2025

Uh oh!

iupaikov-amd commented Aug 29, 2025

Uh oh!

jataylo commented Sep 3, 2025

Uh oh!

pytorchmergebot commented Sep 3, 2025

Uh oh!

pytorchmergebot commented Sep 3, 2025

Uh oh!

jataylo commented Sep 9, 2025

Uh oh!

pytorchmergebot commented Sep 9, 2025

Uh oh!

pytorchmergebot commented Sep 9, 2025

Uh oh!

jataylo commented Nov 24, 2025

Uh oh!

Uh oh!

jataylo commented Dec 1, 2025

Uh oh!

pytorchmergebot commented Dec 1, 2025

Uh oh!

pytorchmergebot commented Dec 1, 2025

Uh oh!

jataylo commented Dec 3, 2025

Uh oh!

pytorchmergebot commented Dec 3, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jataylo commented Jul 25, 2025 •

edited

Loading

pytorch-bot bot commented Jul 25, 2025 •

edited

Loading