Skip to content

Revert "Add NVSHMEM to PYTORCH_EXTRA_INSTALL_REQUIREMENTS (#154568)" #158039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
atalman merged 1 commit into from
Jul 11, 2025
Merged

Revert "Add NVSHMEM to PYTORCH_EXTRA_INSTALL_REQUIREMENTS (#154568)" #158039

atalman merged 1 commit into from
Jul 11, 2025

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jul 10, 2025

Reverting (#154568)

@atalman atalman requested a review from a team as a code owner July 10, 2025 16:45
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158039

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0495faf with merge base 3a7ff82 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR release notes: releng release notes category labels Jul 10, 2025
albanD
albanD approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

@atalman atalman mentioned this pull request Jul 10, 2025
Open
kwen2501
kwen2501 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@youkaichao
Copy link
Collaborator

youkaichao commented Jul 11, 2025

curious to learn what's breaking to motivate this revert?

@albanD
Copy link
Collaborator

albanD commented Jul 11, 2025

This feature is not actually shipped in the wheel so this dependency is not needed.
And there are unknowns on how this dependency will play with other libraries like deepspeed or vllm that ship modified versions of nvshmem

@atalman atalman merged commit 0afa9af into pytorch:release/2.8 Jul 11, 2025
105 of 106 checks passed
@atalman atalman mentioned this pull request Jul 23, 2025
Closed
79 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@kwen2501 kwen2501 kwen2501 approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR release notes: releng release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @youkaichao @albanD @kwen2501