Add serialized_type_name to torch.return_types.* so we can dump them #155245
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155245
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 9 Cancelled Jobs, 7 Unrelated FailuresAs of commit f27e4b8 with merge base 05dd638 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D76058746 |
yushangdi
force-pushed
the
export-D76058746
branch
from
9892558 to
2133bdb
Compare
yushangdi
force-pushed
the
export-D76058746
branch
from
2133bdb to
7a7970d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76058746 |
…ytorch#155245) Summary: Pull Request resolved: pytorch#155245 as title Test Plan: ``` buck run mode/dev-nosan fbcode//caffe2/test:pytree -- -r test_pytree_serialize_torch_return_types ``` Rollback Plan: Differential Revision: D76058746
|
This pull request was exported from Phabricator. Differential Revision: D76058746 |
yushangdi
force-pushed
the
export-D76058746
branch
from
7a7970d to
f27e4b8
Compare
| cls, | ||
| structseq_flatten, | ||
| structseq_unflatten, | ||
| serialized_type_name=f"{cls.__module__}.{cls.__qualname__}", |
There was a problem hiding this comment.
FYI, an old PR uses a constant name "structseq". The PyStructSequence types are static C types. This is not like namedtuple types, which can be created dynamically. So we do not need to worry about the potential change of fully qualified names.
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
4 participants
Summary: as title
Test Plan:
Rollback Plan:
Differential Revision: D76058746