Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Apr 9, 2025

This reverts commit e84bf88.

Fixes #ISSUE_NUMBER

@malfet malfet requested review from eqy and syed-ahmed as code owners April 9, 2025 01:26
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150895

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit c02aba6 with merge base 861d2cc (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ci-no-td Do not run TD on this PR label Apr 9, 2025
@malfet malfet marked this pull request as draft April 9, 2025 01:26
@malfet malfet added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@malfet malfet closed this May 7, 2025
@wsqdhrINnine
Copy link

I wonder to know why this revert came, I found the previous PR #145746 aimed to improve the performance and show us the runtime data. I compiled this pr and found this version seems better than its parent(commit 861d2cc). My GPU is A800, cuda version 12.0
Snipaste_2025-05-27_19-47-45
Is that mean, the reverted PR#145746 may have something wrong in the refinement strategy?

@github-actions github-actions bot deleted the malfet/lets-revert-145746 branch June 27, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants