[pytree] fix previously failed dynamo tests #148669
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148669
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 1 Pending, 1 Unrelated FailureAs of commit 97f792b with merge base e7bc1d1 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| import sys | ||
| import unittest | ||
| from collections import defaultdict, deque, namedtuple, OrderedDict, UserDict | ||
| from collections import defaultdict, namedtuple, OrderedDict, UserDict |
There was a problem hiding this comment.
The test failure is caused by the assertion below:
pytorch/torch/_dynamo/variables/lists.py
Lines 552 to 558 in 5fb0f45
deque is not allowed to be globally imported in the user code. I'm not sure if this assertion is necessary.
There was a problem hiding this comment.
that seems like a bug, can you file a separate issue for it?
There was a problem hiding this comment.
that seems like a bug, can you file a separate issue for it?
Opened a new PR #148676.
ghstack-source-id: 4467210 Pull Request resolved: pytorch#148669
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…code (#148676) See #148669 (comment) for more details. Pull Request resolved: #148676 Approved by: https://github.com/jansel
…code (#148676) See #148669 (comment) for more details. Pull Request resolved: #148676 Approved by: https://github.com/jansel
Stack from ghstack (oldest at bottom):
from collections import dequein user code #148676cc @zou3519 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames