[compiled_autograd] workaround windows compilation issue #148454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch.compile doesn't work on windows so we can ifdef-away the problem. I do not know what the root cause actually is. Most notably, the pytorch windows build is fine, but some third-party projects that use pytorch headers on windows (e.g. torchaudio) have issues. Test Plan: - wait for CI [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148454
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bfdb02a with merge base aade4fb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: compiled autograd
XuehaiPan
reviewed
Mar 4, 2025
torch.compile doesn't work on windows so we can ifdef-away the problem. I do not know what the root cause actually is. Most notably, the pytorch windows build is fine, but some third-party projects that use pytorch headers on windows (e.g. torchaudio) have issues. Test Plan: - wait for CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames xmfan [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Mar 4, 2025
torch.compile doesn't work on windows so we can ifdef-away the problem. I do not know what the root cause actually is. Most notably, the pytorch windows build is fine, but some third-party projects that use pytorch headers on windows (e.g. torchaudio) have issues. Test Plan: - wait for CI ghstack-source-id: be04459 Pull Request resolved: #148454
xmfan
approved these changes
Mar 4, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
reviewed
Mar 5, 2025
| // with certain compiler settings | ||
| // (see https://github.com/pytorch/pytorch/pull/144707 for examples). | ||
| // It's not clear what the problem is, so we're going to ignore it for now. | ||
| TORCH_INTERNAL_ASSERT(false, "torch.compile not supported on Windows"); |
Contributor
There was a problem hiding this comment.
I though torch.compile was supported on Windows, and somehow this only affects Windows builds, so may be a more selective ifdef would be good there
Contributor
Author
There was a problem hiding this comment.
I don't think torch.compile works on windows: #122094, but I've never tried it out. The main problem we had was that triton doesn't work on windows
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 6, 2025
…148570) Pull Request resolved: #148570 Approved by: https://github.com/williamwen42 ghstack dependencies: #148454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
torch.compile doesn't work on windows so we can ifdef-away the problem.
I do not know what the root cause actually is. Most notably, the pytorch
windows build is fine, but some third-party projects that use pytorch headers
on windows (e.g. torchaudio) have issues.
Test Plan:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @xmfan