Skip to content

[CD] Increase timeout for windows binary builds #147390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman wants to merge 1 commit into from
Closed

[CD] Increase timeout for windows binary builds #147390

atalman wants to merge 1 commit into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Feb 18, 2025 •
edited
Loading

Mitigates #147376

@atalman atalman requested a review from a team as a code owner February 18, 2025 19:02
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147390

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 26 Pending

As of commit f1a93e4 with merge base 57060be (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 18, 2025
@jeanschmidt jeanschmidt added the ciflow/nightly Trigger all jobs we run nightly (nightly.yml) label Feb 18, 2025
malfet
malfet approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include before/after stats (and perhaps PR that introduces timeout. 240 min is already ridiculously long)

@atalman
Copy link
Contributor Author

atalman commented Feb 18, 2025 •
edited
Loading

Looks like up to Jan 31, 3h 37m - 3h 50m

And Jan 31 we started seeing timeouts:
edf08cb#diff-ccacb105e82756aa32ba0a7351c6c500ff55eb1c3ac8906a19e0e96b447c65ce

The build time increased to 3h 55m +

@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Feb 18, 2025
@huydhn
Copy link
Contributor

huydhn commented Feb 18, 2025

cc @clee2000 as you might be interested in this increase

@atalman
Copy link
Contributor Author

atalman commented Feb 18, 2025

We are seeing increase in cuda jobs could this be related to CUDA PRs ? Could this issue be related to:
#145746

@atalman
Copy link
Contributor Author

atalman commented Feb 19, 2025

@pytorchmergebot merge -f "lint is green failures are not related"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 19, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

@jeanschmidt jeanschmidt jeanschmidt approved these changes

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/nightly Trigger all jobs we run nightly (nightly.yml) Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atalman @huydhn @pytorchmergebot @malfet @jeanschmidt