[sparse] sparse.mm(), reland #14526 #14661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
weiyangfb
commented
Dec 1, 2018
weiyangfb
commented
- reland reverted PR [sparse] sparse.mm(S, D) #14526 with doc fixes
…that sparse matrix input doesn't have to coalesced
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
nairbv
approved these changes
Dec 3, 2018
Collaborator
nairbv
left a comment
nairbv
left a comment
There was a problem hiding this comment.
ah I see,
(n \times m)(n×m) tensor
needed to be
:math:(n \times m)tensor
in torch/sparse/init.py to avoid non-ascii characters.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Dec 3, 2018
Summary: - reland reverted PR #14526 with doc fixes Pull Request resolved: pytorch/pytorch#14661 Differential Revision: D13289047 Pulled By: weiyangfb fbshipit-source-id: 5b843a11a58b56aeada3af2680a27cf89ecef4d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.