Changes based on @gchanan's review of #13420 #14441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
colesbury
commented
Nov 28, 2018
colesbury
commented
The most significant change is that this fixes the error message when indexing an empty tensor with an out-of-bounds index. For example: x = torch.ones(10, 0) x[:, [3, 4]]
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@colesbury has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Nov 30, 2018
albanD
reviewed
Nov 30, 2018
| Args: | ||
| indices (tuple of LongTensor): tensors used to index into `self`. | ||
| value (Tensor): tensor of same dtype as `self`. | ||
| accumulate (bool): whether to accumulate into self |
Collaborator
There was a problem hiding this comment.
nit: the signature of the function just above is missing accumulate=False.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@colesbury has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 30, 2018
Summary: ``` The most significant change is that this fixes the error message when indexing an empty tensor with an out-of-bounds index. For example: x = torch.ones(10, 0) x[:, [3, 4]] ``` Pull Request resolved: pytorch/pytorch#14441 Differential Revision: D13226737 Pulled By: colesbury fbshipit-source-id: d1c4a35a30e3217e3d1727d13f6b354a4a3b2a24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.