[BE][Ez]: Fix docs recommending inefficient tensor op order #144270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144270
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 91cfdbd with merge base f6488d8 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
force-pushed
the
skylion007/fix-detach-copy-docs-2025-01-06
branch
from
f37b6ae to
e6f98a9
Compare
Skylion007
force-pushed
the
skylion007/fix-detach-copy-docs-2025-01-06
branch
from
e6f98a9 to
91cfdbd
Compare
Skylion007
added
better-engineering
Skylion007
changed the title
awgu
approved these changes
Jan 7, 2025
Collaborator
awgu
left a comment
awgu
left a comment
There was a problem hiding this comment.
This looks reasonable to me!
XuehaiPan
approved these changes
Jan 7, 2025
Collaborator
|
Maybe we can add similar changes to |
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Jan 9, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 9, 2025
…44469) Follow up to #144270 and fix some vulkan code Pull Request resolved: #144469 Approved by: https://github.com/awgu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detach().clone()is faster than.clone().detatch()since the gradients are not cloned. Let's update all the documentation and tests so that users do not use the inefficient op ordering.