-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[ROCm] Prune old gfx archs gfx900/gfx906 from binaries #142827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142827
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 3 Unrelated FailuresAs of commit f6b347e with merge base 2b105de ( NEW FAILURE - The following job has failed:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Libtorch and manywheel docker images built successfully with PYTORCH_ROCM_ARCH not containing gfx900 or gfx906. |
|
@pytorchbot merge -f "Unrelated CI failures". ROCm manywheel/libtorch docker images built successfully" |
|
❌ 🤖 pytorchbot command failed: |
|
@pytorchbot merge -f "Unrelated CI failures. ROCm manywheel/libtorch docker images built successfully" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
I can’t say anything other than that I’m disappointed AMD doesn’t want to compete with Nvidia on software support. |
|
@pytorchbot revert |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot revert -m "prematurely dropped support for gfx900/gfx906" -c weird |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@jithunnair-amd your PR has been successfully reverted. |
…)" This reverts commit 1e2b841. Reverted #142827 on behalf of https://github.com/jeffdaily due to prematurely dropped support for gfx900/gfx906 ([comment](#142827 (comment)))
|
@jeffdaily @jithunnair-amd maybe pursue using offload compression support added to llvm recently as an alternative? |
|
suggestion: generally try focus a bit on things other than forcibly reducing your user base. |
|
#143986 added --offload-compress to our builds to help reduce our binary size without removing gfx arches. There is effort underway to support generic targets, as well. |
|
@jithunnair-amd Who cares about the increasing size of ROCm binaries? Have you listened to your users? People want long-term support so that prosumer and consumer use can be fulfilled. The compute is there, 6700XT is a modern card, and you shouldn't be ending support so soon - especially since this is an argument for people to switch to NVIDIA, since they supported Kepler GPUs (released 2012) till September 2024. |
Remove gfx900 and gfx906 archs as they're long-in-the-tooth. Should help reduce the increasing size of ROCm binaries.
cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd