Skip to content

[ROCm] add gfx1101 to wheels #141667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pruthvistony wants to merge 2 commits into from
Closed

[ROCm] add gfx1101 to wheels #141667

pruthvistony wants to merge 2 commits into from

Conversation

@pruthvistony
Copy link
Collaborator

@pruthvistony pruthvistony commented Nov 27, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141667

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 1 Unrelated Failure

As of commit 239c7d9 with merge base 920e436 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Nov 27, 2024
@pruthvistony pruthvistony added the rocm This tag is for PRs from ROCm team label Nov 27, 2024
@pruthvistony pruthvistony mentioned this pull request Nov 27, 2024
Closed
@pruthvistony
Copy link
Collaborator Author

pruthvistony commented Nov 27, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 27, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pruthvistony @pytorchmergebot
[ROCm] add gfx1101 to wheels
d76e20c 
- Remove older ROCm 5.x build condition
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 27, 2024

Successfully rebased rocm_navi2x_update onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout rocm_navi2x_update && git pull --rebase)

@jeffdaily
Copy link
Collaborator

jeffdaily commented Dec 4, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 4, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jeffdaily
Copy link
Collaborator

jeffdaily commented Dec 4, 2024

@pytorchbot merge -f "rocm-only change to binary build targets; safe to force merge"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@pruthvistony @jeffdaily
[ROCm] add gfx1101 to wheels (pytorch#141667)
7b04c88 
- Remove older ROCm 5.x build condition

Pull Request resolved: pytorch#141667
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@pruthvistony @jeffdaily @AmdSampsa
[ROCm] add gfx1101 to wheels (pytorch#141667)
60f88f5 
- Remove older ROCm 5.x build condition

Pull Request resolved: pytorch#141667
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source rocm This tag is for PRs from ROCm team topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pruthvistony @pytorchmergebot @jeffdaily @pytorchbot