[Inductor][CPP] Extract common functions to be reused in other CPP Template #141554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141554
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 978d68d with merge base f3d16ec ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 26, 2024
leslie-fang-intel
added
topic: not user facing
jgong5
reviewed
Nov 27, 2024
Collaborator
jgong5
left a comment
jgong5
left a comment
There was a problem hiding this comment.
Could you please add function doc for the newly added functions.
Collaborator
Author
Thanks for the comment. Adding the type hint and doc for these new added functions. |
jgong5
requested changes
Nov 27, 2024
| Union[ir.Buffer, ir.ReinterpretView], | ||
| ]: | ||
| """ | ||
| Helper function to pre-process out template epilogues for code generation. |
Collaborator
There was a problem hiding this comment.
Some comments:
- It is more beneficial to explain why we need this function and give a high-level summary of what it does.
- After clarify what it does, you will see it is cleaner to move the building of epilogues out of the function to perhaps a dedicated function.
- Then, you can consider to give a better name to this function according to the function doc.
Suggested change
| Helper function to pre-process out template epilogues for code generation. | |
| The dimension and the indexing could be different between the GEMM output, i.e. `template_buffer`, which is | |
| 2D with MxN) and the output from the template after epilogues, i.e. `Y`. In the GEMM template code, | |
| we are not aware of the dimension and the indexing of the epilogues and always work on 2D tiles according to | |
| the indexing of the GEMM output. | |
| In this function, we return a 2D buffer (`Y_2d`) according to GEMM output (reinterpreted from `Y` if needed) and | |
| build a reindexer that converts the indexing of `Y` into `Y_2d`. |
Collaborator
Author
There was a problem hiding this comment.
Thanks for the comment. Refactor the implementation by removing epilogues and rename this function to gen_2d_view_of_epilogue_buf.
jgong5
approved these changes
Nov 27, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…mplate (pytorch#141554) **Summary** Extract common internal functions from GEMM Template into public function, so these functions can be reused by the subsequent group GEMM template. Pull Request resolved: pytorch#141554 Approved by: https://github.com/jgong5
leslie-fang-intel
added a commit
to leslie-fang-intel/pytorch
that referenced
this pull request
Dec 9, 2024
…mplate ghstack-source-id: 06a63d9 Pull Request resolved: pytorch#141554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Extract common internal functions from GEMM Template into public function, so these functions can be reused by the subsequent group GEMM template.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov