Minor fix to reenable nvtx sequence numbers for the forward methods of custom (Python) autograd functions #13876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… custom (Python) autograd functions
ezyang
approved these changes
Nov 13, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
No chance we could get a test, could we?
apaszke
approved these changes
Nov 13, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
Author
|
@ezyang I'm not sure how. A test would have to do something like run nvprof on a standalone file to completion, spit out an nvvp dump, then open it (separately) and parse the sqlite database. Any suggestions? |
Contributor
|
That would probably be the most likely way to work. Maybe not worth the effort. But I promise you we will accidentally break it without any tests at some point in the future, if someone else touches this code ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our arch people (@mkolod, Aditya Agrawal, @kevinstephano) notified me that the sequence number annotations weren't showing up for forward methods of custom autograd functions, which was breaking their nvprof dump parsing. Two one-line fixes in the appropriate code paths.