roll along multiple dimensions #13874
Conversation
|
@pytorch retest this please getting "RuntimeError: Address already in use" |
|
@pytorchbot retest this please still getting RuntimeError: Address already in use |
|
should the documentation be updated? |
ah, the existing documentation mostly covered this case "(int or tuple of ints)," but I updated to clarify this use case a bit. |
|
numpy.roll also allows an int shift to be used with a tuple axis, applying the same shift to all dimensions. This revision doesn't support that case, requiring shifts.size==dims.size unless dims==None |
| auto tail_shifts = shifts.slice(1); | ||
| auto tail_dims = dims.slice(1); | ||
| auto first_dim_rolled = roll(self, shifts[0], dims[0]); | ||
| return roll(first_dim_rolled, tail_shifts, tail_dims); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@nairbv is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Pull Request resolved: pytorch/pytorch#13874 Differential Revision: D13223669 Pulled By: nairbv fbshipit-source-id: 1678d52529c326fa4a0614d0994b1820ad12bc04
5 participants
No description provided.