Skip to content

Use RNG mutex for randperm on CPU #13832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yf225 wants to merge 1 commit into from
Closed

Use RNG mutex for randperm on CPU #13832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions aten/src/ATen/native/TensorFactories.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include "ATen/core/Deprecated.h"
#include "ATen/core/TensorOptions.h"
#include "TH/THRandom.h"
#include "TH/THGenerator.hpp"
#include "c10/util/Exception.h"

#include <algorithm>
Expand Down Expand Up @@ -428,6 +429,7 @@ Tensor randn_like(const Tensor& self, const TensorOptions& options) {
namespace {
template <typename scalar_t>
void randperm_cpu(Tensor& result, int64_t n, THGenerator* generator) {
std::lock_guard<std::mutex> lock(generator->mutex);
scalar_t *r__data = result.data<scalar_t>();

result.resize_({n});
Expand Down
2 changes: 2 additions & 0 deletions aten/src/TH/generic/THTensorMoreMath.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#else

#include <TH/generic/THTensorApply.hpp>
#include <TH/THGenerator.hpp>

void THTensor_(baddbmm)(THTensor *result, scalar_t beta, THTensor *t, scalar_t alpha, THTensor *batch1, THTensor *batch2)
{
Expand Down Expand Up @@ -650,6 +651,7 @@ void THTensor_(arange)(THTensor *r_, accreal xmin, accreal xmax, accreal step) {

void THTensor_(randperm)(THTensor *r_, THGenerator *_generator, int64_t n)
{
std::lock_guard<std::mutex> lock(_generator->mutex);
scalar_t *r__data;
int64_t r__stride_0;
int64_t i;
Expand Down