Skip to content

[FX][export][dynamo] use tuple instead of list in exported code signature #138213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XuehaiPan wants to merge 17 commits into from
Closed

[FX][export][dynamo] use tuple instead of list in exported code signature #138213

XuehaiPan wants to merge 17 commits into from

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Oct 17, 2024 •
edited by pytorch-bot bot
Loading

@XuehaiPan
Update
45118dc 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138213

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 68d1812 with merge base aade4fb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: dynamo release notes: fx release notes category labels Oct 17, 2024
This was referenced Oct 17, 2024
Closed
Closed
Closed
Closed
@XuehaiPan
Update
d93b79a 
[ghstack-poisoned]
@XuehaiPan
Update
c0bdb8c 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list exported code sign…
e804663 
…ature

ghstack-source-id: 65f9b65
Pull Request resolved: pytorch#138213
@XuehaiPan
Update
1c9749f 
[ghstack-poisoned]
@XuehaiPan
Update
955dca6 
[ghstack-poisoned]
@XuehaiPan
Update
551407b 
[ghstack-poisoned]
@XuehaiPan
Update
01bbba8 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list exported code sign…
c37aa2e 
…ature

ghstack-source-id: 7fa135e
Pull Request resolved: pytorch#138213
@XuehaiPan
Update
02625dd 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 24, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list exported code sign…
e54d095 
…ature

ghstack-source-id: 97a6e93
Pull Request resolved: pytorch#138213
@XuehaiPan
Update
76cfed3 
[ghstack-poisoned]
@XuehaiPan
Update
60bbbf3 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 24, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list exported code sign…
222e28b 
…ature

ghstack-source-id: 56262cd
Pull Request resolved: pytorch#138213
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 24, 2024
@XuehaiPan
Update
0c601a7 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Dec 25, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list exported code sign…
21ecc06 
…ature

ghstack-source-id: 8c96ca2
Pull Request resolved: #138213
@XuehaiPan
Update
53b9ba4 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Mar 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 4, 2025

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@XuehaiPan XuehaiPan requested review from jansel and removed request for Chillee March 4, 2025 18:05
@XuehaiPan XuehaiPan changed the title [FX][export][dynamo] use tuple instead of list exported code signature [FX][export][dynamo] use tuple instead of list in exported code signature Mar 4, 2025
@XuehaiPan
Update
68d1812 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Mar 4, 2025
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in exported code s…
92ee2a3 
…ignature

ghstack-source-id: 84189cd
Pull Request resolved: #138213
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Mar 5, 2025

The benchmark results do not show changing the args type to tuple will be faster. Passing on this.

@XuehaiPan XuehaiPan closed this Mar 5, 2025
@github-actions github-actions bot deleted the gh/XuehaiPan/188/head branch April 11, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@justinchuby justinchuby Awaiting requested review from justinchuby

@wschin wschin Awaiting requested review from wschin

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@ezyang ezyang Awaiting requested review from ezyang

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: dynamo module: inductor no-stale open source release notes: export release notes: fx release notes category Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XuehaiPan @pytorchmergebot @ezyang @titaiwangms @pytorchbot