[POC][FX][pytree] cleanup fx pytree implementation #138202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138202
Note: Links to docs will display an error until the docs builds have been completed. ❌ 27 New FailuresAs of commit e870dbc with merge base ab81ca5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
XuehaiPan
commented
Oct 17, 2024
XuehaiPan
requested review from
justinchuby,
shubhambhokare1,
titaiwangms and
wschin
as code owners
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Oct 17, 2024
ghstack-source-id: f40229f Pull Request resolved: pytorch#138202
Skylion007
reviewed
Oct 17, 2024
XuehaiPan
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
treespec_{leaf,tuple,dict}functions for args_spec modification #138214This PR uses the key path API (generated by
tree_flatten_with_path) to index through the pytree wrapped withtorch.fx.Proxy. This allows us to support third-party containers and simplify the implementation of fx pytree.cc @zou3519 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @rec